services/service_manager/public/cpp/lib/service_runner.cc - Issue 2701883002: service_manager: More consistent Service lifecycle API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/service_manager/public/cpp/lib/service_runner.cc

Issue 2701883002: service_manager: More consistent Service lifecycle API (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/service_manager/public/cpp/lib/service_runner.cc

diff --git a/services/service_manager/public/cpp/lib/service_runner.cc b/services/service_manager/public/cpp/lib/service_runner.cc

index 374a9483ca2416a4237a8cee6db957951a6be308..4ba2f58e87f22c5f4452e598fb56fce7a0fdef55 100644

--- a/services/service_manager/public/cpp/lib/service_runner.cc

+++ b/services/service_manager/public/cpp/lib/service_runner.cc

@@ -57,7 +57,7 @@ MojoResult ServiceRunner::Run(MojoHandle service_request_handle,

mojo::MakeRequest<mojom::Service>(mojo::MakeScopedHandle(

mojo::MessagePipeHandle(service_request_handle)))));

base::RunLoop run_loop;

- context_->SetConnectionLostClosure(run_loop.QuitClosure());

+ context_->SetQuitClosure(run_loop.QuitClosure());

run_loop.Run();

context_.reset();

}