service_manager: More consistent Service lifecycle API

services/tracing/service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/tracing/service.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 10 matching lines @@
 Service::~Service() {}
 
 bool Service::OnConnect(const service_manager::ServiceInfo& remote_info,
                         service_manager::InterfaceRegistry* registry) {
   registry->AddInterface<mojom::Factory>(this);
   registry->AddInterface<mojom::Collector>(this);
   registry->AddInterface<mojom::StartupPerformanceDataCollector>(this);
   return true;
 }
 
-bool Service::OnStop() {
+bool Service::OnServiceManagerConnectionLost() {
   // TODO(beng): This is only required because Service isn't run by
   // ServiceRunner - instead it's launched automatically by the standalone
   // service manager. It shouldn't be.
   base::MessageLoop::current()->QuitWhenIdle();
   return false;
 }
 
 void Service::Create(const service_manager::Identity& remote_identity,
                      mojom::FactoryRequest request) {
   bindings_.AddBinding(this, std::move(request));
@@ skipping 136 matching lines @@
     const GetStartupPerformanceTimesCallback& callback) {
   callback.Run(startup_performance_times_.Clone());
 }
 
 void Service::AllDataCollected() {
   recorder_impls_.clear();
   sink_.reset();
 }
 
 }  // namespace tracing