dbus/message.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/message.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus/message.cc

diff --git a/dbus/message.cc b/dbus/message.cc

index eaf3c9bed9c4a101f4dfc9183dcade489519e8f4..c9219b7e52bd3be8f70d9500c92a02df1472d856 100644

--- a/dbus/message.cc

+++ b/dbus/message.cc

@@ -507,7 +507,7 @@ void MessageWriter::AppendDouble(double value) {

void MessageWriter::AppendString(const std::string& value) {

// D-Bus Specification (0.19) says a string "must be valid UTF-8".

- CHECK(IsStringUTF8(value));

+ CHECK(base::IsStringUTF8(value));

const char* pointer = value.c_str();

AppendBasic(DBUS_TYPE_STRING, &pointer);

// TODO(satorux): It may make sense to return an error here, as the