content/renderer/media/webmediaplayer_impl.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index fa614a4b93b4e46ff67844be333e67309b34c40c..1612f8673e20436bb32e24b91634ac1376317aa5 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -746,7 +746,8 @@ static void ReportMediaKeyExceptionToUMA(const std::string& method,

// Convert a WebString to ASCII, falling back on an empty string in the case

// of a non-ASCII string.

static std::string ToASCIIOrEmpty(const blink::WebString& string) {

- return IsStringASCII(string) ? base::UTF16ToASCII(string) : std::string();

+ return base::IsStringASCII(string) ? base::UTF16ToASCII(string)

+ : std::string();

}

WebMediaPlayer::MediaKeyException