components/bookmarks/core/browser/bookmark_codec.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/core/browser/bookmark_codec.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/core/browser/bookmark_codec.cc

diff --git a/components/bookmarks/core/browser/bookmark_codec.cc b/components/bookmarks/core/browser/bookmark_codec.cc

index 77357af7903426b4f55abf4ff1a075b1f096f5ec..bbf8aa5840c3b31750339ffca756115b86acce98 100644

--- a/components/bookmarks/core/browser/bookmark_codec.cc

+++ b/components/bookmarks/core/browser/bookmark_codec.cc

@@ -464,7 +464,7 @@ void BookmarkCodec::UpdateChecksum(const base::string16& str) {

void BookmarkCodec::UpdateChecksumWithUrlNode(const std::string& id,

const base::string16& title,

const std::string& url) {

- DCHECK(IsStringUTF8(url));

+ DCHECK(base::IsStringUTF8(url));

UpdateChecksum(id);

UpdateChecksum(title);

UpdateChecksum(kTypeURL);