chrome/installer/util/installer_state.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/installer_state.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/installer_state.cc

diff --git a/chrome/installer/util/installer_state.cc b/chrome/installer/util/installer_state.cc

index a5ed9d96e8842f93c1cab359f9ea1ee0eb51ca9f..e6cc475e5e40ad3bb44ecda8127bea74dbe3fac6 100644

--- a/chrome/installer/util/installer_state.cc

+++ b/chrome/installer/util/installer_state.cc

@@ -661,7 +661,7 @@ void InstallerState::GetExistingExeVersions(

FileVersionInfo::CreateFileVersionInfo(chrome_exe));

if (file_version_info) {

base::string16 version_string = file_version_info->file_version();

- if (!version_string.empty() && IsStringASCII(version_string))

+ if (!version_string.empty() && base::IsStringASCII(version_string))

existing_versions->insert(base::UTF16ToASCII(version_string));

}

« no previous file with comments | « chrome/common/net/url_fixer_upper.cc ('k') | chromeos/network/shill_property_util.cc » ('j') | no next file with comments »