Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2904)

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more minor nit Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/net_internals/net_internals_ui.cc
diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
index 6ca3b5e09c8984b98a696f7fd6e4f1dcf42a7efd..e3db035fa82f385b3b3caf58c1f3a08eedb94f51 100644
--- a/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
@@ -1201,7 +1201,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSQuery(
CHECK(list->GetString(0, &domain));
base::DictionaryValue* result = new base::DictionaryValue();
- if (!IsStringASCII(domain)) {
+ if (!base::IsStringASCII(domain)) {
result->SetString("error", "non-ASCII domain name");
} else {
net::TransportSecurityState* transport_security_state =
@@ -1242,7 +1242,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSAdd(
// include subdomains>, <key pins>].
std::string domain;
CHECK(list->GetString(0, &domain));
- if (!IsStringASCII(domain)) {
+ if (!base::IsStringASCII(domain)) {
// Silently fail. The user will get a helpful error if they query for the
// name.
return;
@@ -1276,7 +1276,7 @@ void NetInternalsMessageHandler::IOThreadImpl::OnHSTSDelete(
// |list| should be: [<domain to query>].
std::string domain;
CHECK(list->GetString(0, &domain));
- if (!IsStringASCII(domain)) {
+ if (!base::IsStringASCII(domain)) {
// There cannot be a unicode entry in the HSTS set.
return;
}

Powered by Google App Engine
This is Rietveld 408576698