chrome/browser/spellchecker/spellcheck_custom_dictionary.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_custom_dictionary.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/spellchecker/spellcheck_custom_dictionary.cc

diff --git a/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc b/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc

index a34c7b6f97d8205280984124f8cec361a127a1d2..e7b9140f1f5b8be7658a4c0f57df5a629fe0c391 100644

--- a/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc

+++ b/chrome/browser/spellchecker/spellcheck_custom_dictionary.cc

@@ -76,7 +76,7 @@ ChecksumStatus LoadFile(const base::FilePath& file_path, WordList& words) {

// Returns true for invalid words and false for valid words.

bool IsInvalidWord(const std::string& word) {

std::string tmp;

- return !IsStringUTF8(word) ||

+ return !base::IsStringUTF8(word) ||

word.length() >

chrome::spellcheck_common::MAX_CUSTOM_DICTIONARY_WORD_BYTES ||

word.empty() ||