chrome/browser/net/firefox_proxy_settings.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/firefox_proxy_settings.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/net/firefox_proxy_settings.cc

diff --git a/chrome/browser/net/firefox_proxy_settings.cc b/chrome/browser/net/firefox_proxy_settings.cc

index bc3b04fdaeaaf88f169b8905543d8cb2694899d9..ba7fe94f87053b115c3d2fa0cca55e069ccc9401 100644

--- a/chrome/browser/net/firefox_proxy_settings.cc

+++ b/chrome/browser/net/firefox_proxy_settings.cc

@@ -118,7 +118,7 @@ bool ParsePrefFile(const base::FilePath& pref_file,

value = value.substr(1, value.size() - 2);

// ValueString only accept valid UTF-8. Simply ignore that entry if it is

// not UTF-8.

- if (IsStringUTF8(value))

+ if (base::IsStringUTF8(value))

prefs->SetString(key, value);

else

VLOG(1) << "Non UTF8 value for key " << key << ", ignored.";