chrome/browser/extensions/api/serial/serial_connection.cc - Issue 270183002: Move IsStringUTF8/ASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_connection.cc

Issue 270183002: Move IsStringUTF8/ASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_connection.cc

diff --git a/chrome/browser/extensions/api/serial/serial_connection.cc b/chrome/browser/extensions/api/serial/serial_connection.cc

index 8ff045e0d8b051ce10605c635196d98e68db8b0d..367190144b8e7c5af54140b81db86d6f59875366 100644

--- a/chrome/browser/extensions/api/serial/serial_connection.cc

+++ b/chrome/browser/extensions/api/serial/serial_connection.cc

@@ -164,7 +164,7 @@ void SerialConnection::StartOpen() {

// It's the responsibility of the API wrapper around SerialConnection to

// validate the supplied path against the set of valid port names, and

// it is a reasonable assumption that serial port names are ASCII.

- DCHECK(IsStringASCII(port_));

+ DCHECK(base::IsStringASCII(port_));

base::FilePath path(

base::FilePath::FromUTF8Unsafe(MaybeFixUpPortName(port_)));

int flags = base::File::FLAG_OPEN | base::File::FLAG_READ |