Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 2701813003: Disable PasswordManagerBrowserTestBase.ShowFormNotSecureOnUsernameField (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <utility> 6 #include <utility>
7 7
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 1810 matching lines...) Expand 10 before | Expand all | Expand 10 after
1821 "window.domAutomationController.send(usernameRect.left);", 1821 "window.domAutomationController.send(usernameRect.left);",
1822 &left)); 1822 &left));
1823 1823
1824 content::SimulateMouseClickAt( 1824 content::SimulateMouseClickAt(
1825 WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(left + 1, 1825 WebContents(), 0, blink::WebMouseEvent::Button::Left, gfx::Point(left + 1,
1826 top + 1)); 1826 top + 1));
1827 // Make sure the popup would be shown. 1827 // Make sure the popup would be shown.
1828 observing_autofill_client->Wait(); 1828 observing_autofill_client->Wait();
1829 } 1829 }
1830 1830
1831 // Flaky on official builds (?): https://crbug.com/693717
1831 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase, 1832 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
1832 ShowFormNotSecureOnUsernameField) { 1833 DISABLED_ShowFormNotSecureOnUsernameField) {
1833 password_manager::ContentPasswordManagerDriverFactory* driver_factory = 1834 password_manager::ContentPasswordManagerDriverFactory* driver_factory =
1834 password_manager::ContentPasswordManagerDriverFactory::FromWebContents( 1835 password_manager::ContentPasswordManagerDriverFactory::FromWebContents(
1835 WebContents()); 1836 WebContents());
1836 ObservingAutofillClient::CreateForWebContents(WebContents()); 1837 ObservingAutofillClient::CreateForWebContents(WebContents());
1837 ObservingAutofillClient* observing_autofill_client = 1838 ObservingAutofillClient* observing_autofill_client =
1838 ObservingAutofillClient::FromWebContents(WebContents()); 1839 ObservingAutofillClient::FromWebContents(WebContents());
1839 password_manager::ContentPasswordManagerDriver* driver = 1840 password_manager::ContentPasswordManagerDriver* driver =
1840 driver_factory->GetDriverForFrame(RenderViewHost()->GetMainFrame()); 1841 driver_factory->GetDriverForFrame(RenderViewHost()->GetMainFrame());
1841 DCHECK(driver); 1842 DCHECK(driver);
1842 driver->GetPasswordAutofillManager()->set_autofill_client( 1843 driver->GetPasswordAutofillManager()->set_autofill_client(
(...skipping 1483 matching lines...) Expand 10 before | Expand all | Expand 10 after
3326 // about all frames, not just the main one. The factories should receive 3327 // about all frames, not just the main one. The factories should receive
3327 // messages for non-main frames, in particular 3328 // messages for non-main frames, in particular
3328 // AutofillHostMsg_PasswordFormsParsed. If that were the first time the 3329 // AutofillHostMsg_PasswordFormsParsed. If that were the first time the
3329 // factories hear about such frames, this would crash. 3330 // factories hear about such frames, this would crash.
3330 tab_strip_model->AddWebContents(detached_web_contents.release(), -1, 3331 tab_strip_model->AddWebContents(detached_web_contents.release(), -1,
3331 ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL, 3332 ::ui::PAGE_TRANSITION_AUTO_TOPLEVEL,
3332 TabStripModel::ADD_ACTIVE); 3333 TabStripModel::ADD_ACTIVE);
3333 } 3334 }
3334 3335
3335 } // namespace password_manager 3336 } // namespace password_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698