fix token type of first token in converted token stream

fix token type of first token in converted token stream

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/dbe5e64c8fd776387f622a027584f7ed528173c1

[danrubel, 2017-02-16 21:12:54]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2017-02-16 22:07:54]

https://codereview.chromium.org/2701723002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_test.dart (right):

https://codereview.chromium.org/2701723002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_test.dart:1193: expect(openBrace.previous.type,
TokenType.EOF);
This seems like a weird place to test this functionality.  How about creating a
new test called something like "test_start_token"?

Also, while we're at it, we should test that the offset of the start token is
correct (currently it's -1 for analyzer's scanner, and 0 for the token stream
from ToAnalyzerTokenStream).

[danrubel, 2017-02-21 14:49:27]

Reworked. PTAL.

https://codereview.chromium.org/2701723002/diff/1/pkg/front_end/test/scanner_...
File pkg/front_end/test/scanner_test.dart (right):

https://codereview.chromium.org/2701723002/diff/1/pkg/front_end/test/scanner_...
pkg/front_end/test/scanner_test.dart:1193: expect(openBrace.previous.type,
TokenType.EOF);
On 2017/02/16 22:07:54, Paul Berry wrote:
> This seems like a weird place to test this functionality.  How about creating
a
> new test called something like "test_start_token"?
> 
> Also, while we're at it, we should test that the offset of the start token is
> correct (currently it's -1 for analyzer's scanner, and 0 for the token stream
> from ToAnalyzerTokenStream).

Good points. Found an already existing test_startAndEnd test and enhanced that
one instead.

[Paul Berry, 2017-02-21 17:01:19]

lgtm

[danrubel, 2017-02-21 17:18:47]

Description was changed from

==========
fix token type of first token in converted token stream
==========

to

==========
fix token type of first token in converted token stream

R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dbe5e64c8fd776387f622a027584f7ed528173c1
==========

[danrubel, 2017-02-21 17:18:48]

Committed patchset #3 (id:40001) manually as
dbe5e64c8fd776387f622a027584f7ed528173c1 (presubmit successful).