installer/linux: add symbolic icon for use in gnome-shell

installer/linux: add symbolic icon for use in gnome-shell

GNOME Shell uses symbolic style for small appicon in top panel

As xdg-icon-resource (used to install icons) does not support svgs
gtk-encode-symbolic-svg was used to create 2 .symbolic.png
with sizes 16 and 32 (for x1 and x2 device scaling factor)

BUG=691793

[svito, 2017-02-16 20:39:11]

razotivs@gmail.com changed reviewers:
+ mmoss@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org

[svito, 2017-02-16 20:39:11]

razotivs@gmail.com changed required reviewers:
+ thestig@chromium.org

[svito, 2017-02-16 20:41:11]

The CQ bit was checked by razotivs@gmail.com

[commit-bot: I haz the power, 2017-02-16 20:42:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:42:16]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Paweł Hajdan Jr., 2017-02-21 09:55:23]

The change looks good to me.

We'll need to figure out how to handle Chrome-branded files before this gets
checked in.

[svito, 2017-02-21 14:51:25]

On 2017/02/21 at 09:55:23, phajdan.jr wrote:
> The change looks good to me.
> 
> We'll need to figure out how to handle Chrome-branded files before this gets
checked in.

Chrome-branded files can just be copied over from Chromium in this case as logos
of both have similar color lightness levels.

Chrome and Chromium being basically same logos but with different colors I see
no problem with this, unless Google wants Chrome logo to be colored independent
of platform or environment to preserve brand identity. As GNOME displays name of
application along with icon this becomes less of an issue.

[Lei Zhang, 2017-02-23 03:06:43]

thestig@chromium.org changed reviewers:
+ thomasanderson@chromium.org

[Lei Zhang, 2017-02-23 03:06:44]

+Tom

Just to be clear, the .svg file is just the source and not intended to be
shipped, correct?

[Tom (Use chromium acct), 2017-02-23 03:11:35]

thomasanderson@google.com changed reviewers:
+ thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-23 03:11:35]

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
File chrome/installer/linux/common/postinst.include (right):

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
chrome/installer/linux/common/postinst.include:12: for icon in
"@@INSTALLDIR@@/product_symbolic_logo_"*.symbolic.png; do
Would it be possible to combine this and the above for loop?

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
File chrome/installer/linux/common/prerm.include (right):

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
chrome/installer/linux/common/prerm.include:12: for icon in
"@@INSTALLDIR@@/product_symbolic_logo_"*.symbolic.png; do
Ditto

[Lei Zhang, 2017-02-23 07:28:31]

Please remember to give yourself credit in the AUTHORS file.

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
File chrome/installer/linux/common/postinst.include (right):

https://codereview.chromium.org/2701703002/diff/1/chrome/installer/linux/comm...
chrome/installer/linux/common/postinst.include:14: "$XDG_ICON_RESOURCE" install
--size "${size%.symbolic.png}" "$icon" "@@PACKAGE@@-symbolic.symbolic"
Like with most code, we limit ourselves to 80 chars / line.

[Tom Anderson, 2017-05-18 01:17:16]

Description was changed from

==========
installer/linux: add symbolic icon for use in gnome-shell

GNOME Shell uses symbolic style for small appicon in top panel

As xdg-icon-resource (used to install icons) does not support svgs
gtk-encode-symbolic-svg was used to create 2 .symbolic.png
with sizes 16 and 32 (for x1 and x2 device scaling factor)

BUG=691793
==========

to

==========
installer/linux: add symbolic icon for use in gnome-shell

GNOME Shell uses symbolic style for small appicon in top panel

As xdg-icon-resource (used to install icons) does not support svgs
gtk-encode-symbolic-svg was used to create 2 .symbolic.png
with sizes 16 and 32 (for x1 and x2 device scaling factor)

BUG=691793
==========

[Tom Anderson, 2017-05-18 01:17:16]

thomasanderson@chromium.org changed reviewers:
- thomasanderson@google.com