Issue 27017003: Fixes for tcmalloc for VS2013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27017003: Fixes for tcmalloc for VS2013 (Closed)

Created:
7 years, 2 months ago by scottmg

Modified:
7 years, 2 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes for tcmalloc for VS2013 - Add missing #include of <algorithm> for std::min/max - strtoll, strtoull, strotoq in runtime on >= VS2013. R=jar@chromium.org BUG=288948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228737

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	third_party/tcmalloc/chromium/src/windows/port.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	third_party/tcmalloc/chromium/src/windows/port.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27017003/1

7 years, 2 months ago (2013-10-11 21:30:47 UTC) #3

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 2 months ago (2013-10-12 02:57:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/27017003/1

7 years, 2 months ago (2013-10-15 17:04:38 UTC) #5

Message was sent while issue was closed.

Change committed as 228737