Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)
Patch Set: fix chromeos compile error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
diff --git a/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h b/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
index 360725b69529713bf44f6a3c2f1005dc4608eece..172d89d009659b10d63830527a05033995cf7383 100644
--- a/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
+++ b/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/ref_counted.h"
#include "base/optional.h"
#include "base/threading/thread_checker.h"
#include "chrome/common/media_router/mojo/dial_device_description_parser.mojom.h"
@@ -29,31 +30,21 @@ class SafeDialDeviceDescriptionParser {
ParseDialDeviceDescriptionCallback;
SafeDialDeviceDescriptionParser();
+ virtual ~SafeDialDeviceDescriptionParser();
// Start parsing device description XML file in utility process.
- void Start(const std::string& xml_text,
- const DeviceDescriptionCallback& callback);
-
- private:
- ~SafeDialDeviceDescriptionParser();
-
- // See SafeDialDeviceDescriptionParser::DeviceDescriptionCallback
- void OnParseDeviceDescriptionComplete(
- chrome::mojom::DialDeviceDescriptionPtr device_description);
-
// TODO(crbug.com/702766): Add an enum type describing why utility process
// fails to parse device description xml.
- void OnParseDeviceDescriptionFailed();
+ virtual void Start(const std::string& xml_text,
+ const DeviceDescriptionCallback& callback);
+ private:
// Utility client used to send device description parsing task to the utility
// process.
std::unique_ptr<content::UtilityProcessMojoClient<
chrome::mojom::DialDeviceDescriptionParser>>
utility_process_mojo_client_;
- // Only accessed on the IO thread.
- DeviceDescriptionCallback device_description_callback_;
-
base::ThreadChecker thread_checker_;
DISALLOW_COPY_AND_ASSIGN(SafeDialDeviceDescriptionParser);

Powered by Google App Engine
This is Rietveld 408576698