chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc - Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)

Patch Set: fix chromeos compile error Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/discovery/dial/dial_device_data.cc ('k') | chrome/browser/media/router/discovery/dial/dial_media_sink_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc

diff --git a/chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc b/chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc

index ac78065d38f7fffa14e49a51ded7999686ed497e..edc95dfc201f114b7f4d7036e96a80321ae8d9b0 100644

--- a/chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc

+++ b/chrome/browser/media/router/discovery/dial/dial_device_data_unittest.cc

@@ -69,9 +69,9 @@ TEST(DialDeviceDataTest, TestUpdateFrom) {

}

TEST(DialDeviceDataTest, TestIsDeviceDescriptionUrl) {

- EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

+ EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(

GURL("http://some.device.com/dd.xml")));

- EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

+ EXPECT_FALSE(DialDeviceData::IsDeviceDescriptionUrl(

GURL("https://some.device.com/dd.xml")));

EXPECT_TRUE(DialDeviceData::IsDeviceDescriptionUrl(

GURL("http://192.168.1.1:1234/dd.xml")));