chrome/browser/media/router/discovery/dial/dial_registry.cc - Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/discovery/dial/dial_registry.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)

Patch Set: resolve code review comments from Derek and Mark Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/router/discovery/dial/dial_registry.cc

diff --git a/chrome/browser/media/router/discovery/dial/dial_registry.cc b/chrome/browser/media/router/discovery/dial/dial_registry.cc

index f394945b5a37ca659178c64addb7078e9ce2c2cb..e5243884a7892dcad9fdbb468e4ba4c70fc7e35e 100644

--- a/chrome/browser/media/router/discovery/dial/dial_registry.cc

+++ b/chrome/browser/media/router/discovery/dial/dial_registry.cc

@@ -126,7 +126,7 @@ void DialRegistry::AddDeviceForTest(const DialDeviceData& device_data) {

}

bool DialRegistry::ReadyToDiscover() {

- if (num_listeners_ == 0) {

+ if (!observers_.might_have_observers()) {

OnDialError(DIAL_NO_LISTENERS);

return false;

}