Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6868)

Unified Diff: chrome/common/media_router/discovery/media_sink_internal_unittest.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)
Patch Set: merge with master Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/media_router/discovery/media_sink_internal_unittest.cc
diff --git a/chrome/common/media_router/discovery/media_sink_internal_unittest.cc b/chrome/common/media_router/discovery/media_sink_internal_unittest.cc
index 220ecda6f33a26c557b9a49f973f1848dfcdbfcb..94ec0bc10f3e2bd22fad3f98e7387b1756f008f6 100644
--- a/chrome/common/media_router/discovery/media_sink_internal_unittest.cc
+++ b/chrome/common/media_router/discovery/media_sink_internal_unittest.cc
@@ -2,60 +2,49 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/media_router/discovery/media_sink_internal.h"
-
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
+#include "chrome/common/media_router/discovery/media_sink_internal_unittest.h"
namespace media_router {
-class MediaSinkInternalTest : public ::testing::Test {
- public:
- MediaSinkInternalTest()
- : media_sink_(sink_id_, sink_name_, MediaSink::IconType::CAST) {}
-
- DialSinkExtraData CreateDialSinkExtraData() {
- return CreateDialSinkExtraData(model_name_, ip_address_, app_url_);
- }
-
- DialSinkExtraData CreateDialSinkExtraData(const std::string& model_name,
- const std::string& ip_address,
- const std::string& app_url) {
- DialSinkExtraData dial_extra_data;
- EXPECT_TRUE(dial_extra_data.ip_address.AssignFromIPLiteral(ip_address));
- dial_extra_data.model_name = model_name;
- dial_extra_data.app_url = GURL(app_url);
+MediaSinkInternalTest::MediaSinkInternalTest()
+ : media_sink_(sink_id_, sink_name_, MediaSink::IconType::CAST) {}
- return dial_extra_data;
- }
+MediaSinkInternalTest::~MediaSinkInternalTest() = default;
- CastSinkExtraData CreateCastSinkExtraData() {
- return CreateCastSinkExtraData(model_name_, ip_address_, 2, 3);
- }
+// static
+DialSinkExtraData MediaSinkInternalTest::CreateDialSinkExtraData(
+ const std::string& model_name,
+ const std::string& ip_address,
+ const std::string& app_url) {
+ DialSinkExtraData dial_extra_data;
+ EXPECT_TRUE(dial_extra_data.ip_address.AssignFromIPLiteral(ip_address));
+ dial_extra_data.model_name = model_name;
+ dial_extra_data.app_url = GURL(app_url);
- CastSinkExtraData CreateCastSinkExtraData(const std::string& model_name,
- const std::string& ip_address,
- uint8_t capabilities,
- int cast_channel_id) {
- CastSinkExtraData cast_extra_data;
- EXPECT_TRUE(cast_extra_data.ip_address.AssignFromIPLiteral(ip_address));
- cast_extra_data.model_name = model_name;
- cast_extra_data.capabilities = 2;
- cast_extra_data.cast_channel_id = 3;
- return cast_extra_data;
- }
+ return dial_extra_data;
+}
- MediaSink media_sink() { return media_sink_; }
+// static
+CastSinkExtraData MediaSinkInternalTest::CreateCastSinkExtraData(
+ const std::string& model_name,
+ const std::string& ip_address,
+ uint8_t capabilities,
+ int cast_channel_id) {
+ CastSinkExtraData cast_extra_data;
+ EXPECT_TRUE(cast_extra_data.ip_address.AssignFromIPLiteral(ip_address));
+ cast_extra_data.model_name = model_name;
+ cast_extra_data.capabilities = 2;
+ cast_extra_data.cast_channel_id = 3;
+ return cast_extra_data;
+}
- private:
- std::string sink_id_ = "sinkId123";
- std::string sink_name_ = "The sink";
- std::string ip_address_ = "192.168.1.2";
- std::string model_name_ = "model name";
- std::string app_url_ = "https://example.com";
+DialSinkExtraData MediaSinkInternalTest::CreateDialSinkExtraData() {
+ return CreateDialSinkExtraData(model_name_, ip_address_, app_url_);
+}
- MediaSink media_sink_;
-};
+CastSinkExtraData MediaSinkInternalTest::CreateCastSinkExtraData() {
+ return CreateCastSinkExtraData(model_name_, ip_address_, 2, 3);
+}
TEST_F(MediaSinkInternalTest, TestIsValidSinkId) {
EXPECT_FALSE(MediaSinkInternal::IsValidSinkId(""));

Powered by Google App Engine
This is Rietveld 408576698