| Index: chrome/browser/media/router/discovery/media_sink_internal_unittest.cc
|
| diff --git a/chrome/browser/media/router/discovery/media_sink_internal_unittest.cc b/chrome/browser/media/router/discovery/media_sink_internal_unittest.cc
|
| index 138208bc24b9424f33215327730fdcce5a47b072..b23bbc8c795a5b2d39571bd7c7021e5d9df4a86b 100644
|
| --- a/chrome/browser/media/router/discovery/media_sink_internal_unittest.cc
|
| +++ b/chrome/browser/media/router/discovery/media_sink_internal_unittest.cc
|
| @@ -2,59 +2,49 @@
|
| // Use of this source code is governed by a BSD-style license that can be
|
| // found in the LICENSE file.
|
|
|
| -#include "chrome/browser/media/router/discovery/media_sink_internal.h"
|
| -#include "testing/gmock/include/gmock/gmock.h"
|
| -#include "testing/gtest/include/gtest/gtest.h"
|
| +#include "chrome/browser/media/router/discovery/media_sink_internal_unittest.h"
|
|
|
| namespace media_router {
|
|
|
| -class MediaSinkInternalTest : public ::testing::Test {
|
| - public:
|
| - MediaSinkInternalTest()
|
| - : media_sink_(sink_id_, sink_name_, MediaSink::IconType::CAST) {}
|
| +MediaSinkInternalTest::MediaSinkInternalTest()
|
| + : media_sink_(sink_id_, sink_name_, MediaSink::IconType::CAST) {}
|
|
|
| - DialSinkExtraData CreateDialSinkExtraData() {
|
| - return CreateDialSinkExtraData(model_name_, ip_address_, app_url_);
|
| - }
|
| -
|
| - DialSinkExtraData CreateDialSinkExtraData(const std::string& model_name,
|
| - const std::string& ip_address,
|
| - const std::string& app_url) {
|
| - DialSinkExtraData dial_extra_data;
|
| - EXPECT_TRUE(dial_extra_data.ip_address.AssignFromIPLiteral(ip_address));
|
| - dial_extra_data.model_name = model_name;
|
| - dial_extra_data.app_url = GURL(app_url);
|
| +MediaSinkInternalTest::~MediaSinkInternalTest() = default;
|
|
|
| - return dial_extra_data;
|
| - }
|
| -
|
| - CastSinkExtraData CreateCastSinkExtraData() {
|
| - return CreateCastSinkExtraData(model_name_, ip_address_, 2, 3);
|
| - }
|
| +// static
|
| +DialSinkExtraData MediaSinkInternalTest::CreateDialSinkExtraData(
|
| + const std::string& model_name,
|
| + const std::string& ip_address,
|
| + const std::string& app_url) {
|
| + DialSinkExtraData dial_extra_data;
|
| + EXPECT_TRUE(dial_extra_data.ip_address.AssignFromIPLiteral(ip_address));
|
| + dial_extra_data.model_name = model_name;
|
| + dial_extra_data.app_url = GURL(app_url);
|
|
|
| - CastSinkExtraData CreateCastSinkExtraData(const std::string& model_name,
|
| - const std::string& ip_address,
|
| - uint8_t capabilities,
|
| - int cast_channel_id) {
|
| - CastSinkExtraData cast_extra_data;
|
| - EXPECT_TRUE(cast_extra_data.ip_address.AssignFromIPLiteral(ip_address));
|
| - cast_extra_data.model_name = model_name;
|
| - cast_extra_data.capabilities = 2;
|
| - cast_extra_data.cast_channel_id = 3;
|
| - return cast_extra_data;
|
| - }
|
| + return dial_extra_data;
|
| +}
|
|
|
| - MediaSink media_sink() { return media_sink_; }
|
| +// static
|
| +CastSinkExtraData MediaSinkInternalTest::CreateCastSinkExtraData(
|
| + const std::string& model_name,
|
| + const std::string& ip_address,
|
| + uint8_t capabilities,
|
| + int cast_channel_id) {
|
| + CastSinkExtraData cast_extra_data;
|
| + EXPECT_TRUE(cast_extra_data.ip_address.AssignFromIPLiteral(ip_address));
|
| + cast_extra_data.model_name = model_name;
|
| + cast_extra_data.capabilities = 2;
|
| + cast_extra_data.cast_channel_id = 3;
|
| + return cast_extra_data;
|
| +}
|
|
|
| - private:
|
| - std::string sink_id_ = "sinkId123";
|
| - std::string sink_name_ = "The sink";
|
| - std::string ip_address_ = "192.168.1.2";
|
| - std::string model_name_ = "model name";
|
| - std::string app_url_ = "https://example.com";
|
| +DialSinkExtraData MediaSinkInternalTest::CreateDialSinkExtraData() {
|
| + return CreateDialSinkExtraData(model_name_, ip_address_, app_url_);
|
| +}
|
|
|
| - MediaSink media_sink_;
|
| -};
|
| +CastSinkExtraData MediaSinkInternalTest::CreateCastSinkExtraData() {
|
| + return CreateCastSinkExtraData(model_name_, ip_address_, 2, 3);
|
| +}
|
|
|
| TEST_F(MediaSinkInternalTest, TestIsValidSinkId) {
|
| EXPECT_FALSE(MediaSinkInternal::IsValidSinkId(""));
|
|
|