Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/media/router/discovery/dial/dial_media_sink_service_unittest.cc

Issue 2701633002: [Media Router] Add DialMediaSinkService and DeviceDescriptionService (Closed)
Patch Set: resolve code review comments from Derek and Mark Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/media/router/discovery/dial/dial_media_sink_service.h"
6 #include "base/test/mock_callback.h"
7 #include "chrome/browser/media/router/discovery/dial/dial_device_data.h"
8 #include "chrome/browser/media/router/discovery/dial/dial_registry.h"
9 #include "chrome/browser/media/router/test_helper.h"
10 #include "chrome/common/media_router/discovery/media_sink_internal_unittest.h"
11 #include "chrome/test/base/testing_profile.h"
12 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h"
15
16 using ::testing::_;
17 using ::testing::Return;
18
19 namespace {
20
21 std::vector<media_router::MediaSinkInternal> CreateDialMediaSinks() {
22 media_router::MediaSink sink1("sink1", "sink_name_1",
23 media_router::MediaSink::IconType::CAST);
24 media_router::DialSinkExtraData extra_data1 =
25 media_router::MediaSinkInternalTest::CreateDialSinkExtraData(
26 "model_name1", "192.168.1.1", "https://example1.com");
27
28 media_router::MediaSink sink2("sink2", "sink_name_2",
29 media_router::MediaSink::IconType::CAST);
30 media_router::DialSinkExtraData extra_data2 =
31 media_router::MediaSinkInternalTest::CreateDialSinkExtraData(
32 "model_name2", "192.168.1.2", "https://example2.com");
33
34 std::vector<media_router::MediaSinkInternal> sinks;
35 sinks.push_back(media_router::MediaSinkInternal(sink1, extra_data1));
36 sinks.push_back(media_router::MediaSinkInternal(sink2, extra_data2));
37 return sinks;
38 }
39
40 } // namespace
41
42 namespace media_router {
43
44 class TestDialRegistry : public DialRegistry {
45 public:
46 TestDialRegistry() {}
47 ~TestDialRegistry() {}
48
49 MOCK_METHOD1(RegisterObserver, void(DialRegistry::Observer* observer));
50 MOCK_METHOD1(UnregisterObserver, void(DialRegistry::Observer* observer));
51 };
52
53 class MockDeviceDescriptionService : public DeviceDescriptionService {
54 public:
55 MockDeviceDescriptionService(DeviceDescriptionParseSuccessCallback success_cb,
56 DeviceDescriptionParseErrorCallback error_cb)
57 : DeviceDescriptionService(success_cb, error_cb) {}
58 ~MockDeviceDescriptionService() override {}
59
60 MOCK_METHOD2(GetDeviceDescriptions,
61 void(const std::vector<DialDeviceData>& devices,
62 net::URLRequestContextGetter* request_context));
63 };
64
65 class TestDialMediaSinkService : public DialMediaSinkService {
66 public:
67 TestDialMediaSinkService(
68 const MediaSinkService::OnSinksDiscoveredCallback& callback,
69 content::BrowserContext* browser_context,
70 net::URLRequestContextGetter* request_context,
71 TestDialRegistry* test_dial_registry,
72 MockDeviceDescriptionService* mock_description_service)
73 : DialMediaSinkService(callback, browser_context, request_context),
74 test_dial_registry_(test_dial_registry),
75 mock_description_service_(mock_description_service) {}
76
77 DialRegistry* dial_registry() override { return test_dial_registry_; }
78
79 DeviceDescriptionService* GetDescriptionService() override {
80 return mock_description_service_;
81 }
82
83 private:
84 TestDialRegistry* test_dial_registry_;
85 MockDeviceDescriptionService* mock_description_service_;
86 };
87
88 class DialMediaSinkServiceTest : public ::testing::Test {
89 public:
90 DialMediaSinkServiceTest()
91 : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
92 mock_description_service_(mock_success_cb_.Get(), mock_error_cb_.Get()),
93 media_sink_service_(mock_sink_discovered_cb_.Get(),
94 &profile_,
95 profile_.GetRequestContext(),
96 &test_dial_registry_,
97 &mock_description_service_) {}
98
99 DialMediaSinkService* media_sink_service() { return &media_sink_service_; }
100
101 void TestFetchCompleted(const std::vector<MediaSinkInternal>& old_sinks,
102 const std::vector<MediaSinkInternal>& new_sinks) {
103 media_sink_service()->mrp_sinks_ =
104 std::set<MediaSinkInternal>(old_sinks.begin(), old_sinks.end());
105 media_sink_service()->current_sinks_ =
106 std::set<MediaSinkInternal>(new_sinks.begin(), new_sinks.end());
107 EXPECT_CALL(mock_sink_discovered_cb_, Run(new_sinks));
108 media_sink_service()->OnFetchCompleted();
109 }
110
111 protected:
112 const content::TestBrowserThreadBundle thread_bundle_;
113 TestingProfile profile_;
114
115 base::MockCallback<MediaSinkService::OnSinksDiscoveredCallback>
116 mock_sink_discovered_cb_;
117 base::MockCallback<
118 MockDeviceDescriptionService::DeviceDescriptionParseSuccessCallback>
119 mock_success_cb_;
120 base::MockCallback<
121 MockDeviceDescriptionService::DeviceDescriptionParseErrorCallback>
122 mock_error_cb_;
123
124 TestDialRegistry test_dial_registry_;
125 MockDeviceDescriptionService mock_description_service_;
126
127 TestDialMediaSinkService media_sink_service_;
128 };
129
130 TEST_F(DialMediaSinkServiceTest, TestStart) {
131 EXPECT_CALL(test_dial_registry_, RegisterObserver(&media_sink_service_));
132 media_sink_service()->Start();
133
134 DialRegistry::DeviceList deviceList;
135 DialDeviceData first_device("first", GURL("http://127.0.0.1/dd.xml"),
136 base::Time::Now());
137 DialDeviceData second_device("second", GURL("http://127.0.0.2/dd.xml"),
138 base::Time::Now());
139 DialDeviceData third_device("third", GURL("http://127.0.0.3/dd.xml"),
140 base::Time::Now());
141 deviceList.push_back(first_device);
142 deviceList.push_back(second_device);
143 deviceList.push_back(third_device);
144
145 EXPECT_CALL(mock_description_service_, GetDeviceDescriptions(deviceList, _));
146
147 media_sink_service()->OnDialDeviceEvent(deviceList);
148 EXPECT_TRUE(media_sink_service_.finish_timer_->IsRunning());
149 }
150
151 TEST_F(DialMediaSinkServiceTest, TestOnDeviceDescriptionAvailable) {
152 DialDeviceData device_data("first", GURL("http://127.0.0.1/dd.xml"),
153 base::Time::Now());
154 ParsedDialDeviceDescription device_description;
155 device_description.model_name = "model name";
156 device_description.friendly_name = "friendly name";
157 device_description.app_url = GURL("http://192.168.1.1/apps");
158 device_description.unique_id = "unique id";
159
160 media_sink_service()->OnDeviceDescriptionAvailable(device_data,
161 device_description);
162 EXPECT_TRUE(media_sink_service()->current_sinks_.empty());
163
164 std::vector<DialDeviceData> deviceList{device_data};
165 EXPECT_CALL(mock_description_service_, GetDeviceDescriptions(deviceList, _));
166
167 media_sink_service()->OnDialDeviceEvent(deviceList);
168 media_sink_service()->OnDeviceDescriptionAvailable(device_data,
169 device_description);
170
171 EXPECT_EQ(size_t(1), media_sink_service()->current_sinks_.size());
172 }
173
174 TEST_F(DialMediaSinkServiceTest, TestFetchCompleted) {
175 std::vector<MediaSinkInternal> old_sinks;
176 std::vector<MediaSinkInternal> new_sinks = CreateDialMediaSinks();
177 TestFetchCompleted(old_sinks, new_sinks);
178
179 // Same sink
180 EXPECT_CALL(mock_sink_discovered_cb_, Run(new_sinks)).Times(0);
181 media_sink_service()->OnFetchCompleted();
182 }
183
184 TEST_F(DialMediaSinkServiceTest, TestFetchCompleted_OneNewSink) {
185 std::vector<MediaSinkInternal> old_sinks = CreateDialMediaSinks();
186 std::vector<MediaSinkInternal> new_sinks = CreateDialMediaSinks();
187 MediaSink sink3("sink3", "sink_name_3", MediaSink::IconType::CAST);
188 DialSinkExtraData extra_data3 =
189 MediaSinkInternalTest::CreateDialSinkExtraData(
190 "model_name3", "192.168.1.3", "https://example3.com");
191 new_sinks.push_back(MediaSinkInternal(sink3, extra_data3));
192 TestFetchCompleted(old_sinks, new_sinks);
193 }
194
195 TEST_F(DialMediaSinkServiceTest, TestFetchCompleted_RemovedOneSink) {
196 std::vector<MediaSinkInternal> old_sinks = CreateDialMediaSinks();
197 std::vector<MediaSinkInternal> new_sinks = CreateDialMediaSinks();
198 new_sinks.erase(new_sinks.begin());
199 TestFetchCompleted(old_sinks, new_sinks);
200 }
201
202 TEST_F(DialMediaSinkServiceTest, TestFetchCompleted_UpdatedOneSink) {
203 std::vector<MediaSinkInternal> old_sinks = CreateDialMediaSinks();
204 std::vector<MediaSinkInternal> new_sinks = CreateDialMediaSinks();
205 new_sinks[0].set_name("sink_name_4");
206 TestFetchCompleted(old_sinks, new_sinks);
207 }
208
209 TEST_F(DialMediaSinkServiceTest, TestFetchCompleted_Mixed) {
210 std::vector<MediaSinkInternal> old_sinks = CreateDialMediaSinks();
211
212 MediaSink sink1("sink1", "sink_name_1", MediaSink::IconType::CAST);
213 DialSinkExtraData extra_data2 =
214 MediaSinkInternalTest::CreateDialSinkExtraData(
215 "model_name2", "192.168.1.2", "https://example2.com");
216
217 MediaSink sink3("sink3", "sink_name_3", MediaSink::IconType::CAST);
218 DialSinkExtraData extra_data3 =
219 MediaSinkInternalTest::CreateDialSinkExtraData(
220 "model_name3", "192.168.1.3", "https://example3.com");
221
222 std::vector<MediaSinkInternal> new_sinks;
223 new_sinks.push_back(MediaSinkInternal(sink1, extra_data2));
224 new_sinks.push_back(MediaSinkInternal(sink3, extra_data3));
225
226 TestFetchCompleted(old_sinks, new_sinks);
227 }
228
229 } // namespace media_router
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698