Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: chromecast/media/cma/pipeline/media_pipeline_impl.cc

Issue 2701613006: [Chromecast] Process streams with different post-processing. (Closed)
Patch Set: Fix nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/pipeline/media_pipeline_impl.cc
diff --git a/chromecast/media/cma/pipeline/media_pipeline_impl.cc b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
index 14ced50a4d383c37ea7f16eac46266c695ab54b9..38473d767bb90a9709cdeabe3cd6091ba163a2ac 100644
--- a/chromecast/media/cma/pipeline/media_pipeline_impl.cc
+++ b/chromecast/media/cma/pipeline/media_pipeline_impl.cc
@@ -43,6 +43,12 @@ const base::TimeDelta kLowBufferThresholdMediaSource(
const base::TimeDelta kHighBufferThresholdMediaSource(
base::TimeDelta::FromMilliseconds(300));
+// Buffering parameters when load_type is kLoadTypeLiveSource.
+const base::TimeDelta kLowBufferThresholdLiveSource(
+ base::TimeDelta::FromMilliseconds(0));
+const base::TimeDelta kHighBufferThresholdLiveSource(
+ base::TimeDelta::FromMilliseconds(60));
wzhong 2017/02/21 16:03:46 Nah... Those are not POD and should be banned.
kmackay 2017/02/21 16:08:47 These are OK now as long as they are constexpr
bshaya 2017/02/21 23:30:14 Acknowledged.
+
// Interval between two updates of the media time.
const base::TimeDelta kTimeUpdateInterval(
base::TimeDelta::FromMilliseconds(250));
@@ -123,6 +129,9 @@ void MediaPipelineImpl::Initialize(
if (load_type == kLoadTypeMediaSource) {
low_threshold = kLowBufferThresholdMediaSource;
high_threshold = kHighBufferThresholdMediaSource;
+ } else if (load_type == kLoadTypeLiveSource) {
+ low_threshold = kLowBufferThresholdLiveSource;
+ high_threshold = kHighBufferThresholdLiveSource;
}
scoped_refptr<BufferingConfig> buffering_config(
new BufferingConfig(low_threshold, high_threshold));

Powered by Google App Engine
This is Rietveld 408576698