Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: chromecast/public/media/media_pipeline_device_params.h

Issue 2701613006: [Chromecast] Process streams with different post-processing. (Closed)
Patch Set: Fix nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_PUBLIC_MEDIA_MEDIA_PIPELINE_DEVICE_PARAMS_H_ 5 #ifndef CHROMECAST_PUBLIC_MEDIA_MEDIA_PIPELINE_DEVICE_PARAMS_H_
6 #define CHROMECAST_PUBLIC_MEDIA_MEDIA_PIPELINE_DEVICE_PARAMS_H_ 6 #define CHROMECAST_PUBLIC_MEDIA_MEDIA_PIPELINE_DEVICE_PARAMS_H_
7 7
8 namespace chromecast { 8 namespace chromecast {
9 class TaskRunner; 9 class TaskRunner;
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 audio_type(kAudioStreamNormal), 48 audio_type(kAudioStreamNormal),
49 task_runner(task_runner_in) {} 49 task_runner(task_runner_in) {}
50 50
51 MediaPipelineDeviceParams(MediaSyncType sync_type_in, 51 MediaPipelineDeviceParams(MediaSyncType sync_type_in,
52 AudioStreamType audio_type_in, 52 AudioStreamType audio_type_in,
53 TaskRunner* task_runner_in) 53 TaskRunner* task_runner_in)
54 : sync_type(sync_type_in), 54 : sync_type(sync_type_in),
55 audio_type(audio_type_in), 55 audio_type(audio_type_in),
56 task_runner(task_runner_in) {} 56 task_runner(task_runner_in) {}
57 57
58 MediaPipelineDeviceParams(MediaSyncType sync_type_in,
59 AudioStreamType audio_type_in,
60 std::string name_in,
61 TaskRunner* task_runner_in)
62 : sync_type(sync_type_in),
63 audio_type(audio_type_in),
64 name(name_in),
65 task_runner(task_runner_in) {}
66
58 const MediaSyncType sync_type; 67 const MediaSyncType sync_type;
59 const AudioStreamType audio_type; 68 const AudioStreamType audio_type;
69 const std::string name;
tianyuwang1 2017/02/18 00:17:09 why not just call this device_id to be consistent
kmackay 2017/02/19 23:09:09 This should be last, after task_runner, to preserv
gfhuang 2017/02/21 20:06:31 I don't think it will preserve ABI compatibility s
kmackay 2017/02/21 20:14:39 Object size doesn't matter, since we don't pass it
60 70
61 // task_runner allows backend implementations to post tasks to the media 71 // task_runner allows backend implementations to post tasks to the media
62 // thread. Since all calls from cast_shell into the backend are made on 72 // thread. Since all calls from cast_shell into the backend are made on
63 // the media thread, this may simplify thread management and safety for 73 // the media thread, this may simplify thread management and safety for
64 // some backends. 74 // some backends.
65 TaskRunner* const task_runner; 75 TaskRunner* const task_runner;
66 }; 76 };
67 77
68 } // namespace media 78 } // namespace media
69 } // namespace chromecast 79 } // namespace chromecast
70 80
71 #endif // CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_DEVICE_PARAMS_H_ 81 #endif // CHROMECAST_MEDIA_CMA_BACKEND_MEDIA_PIPELINE_DEVICE_PARAMS_H_
OLDNEW
« chromecast/public/media/audio_device_ids.h ('K') | « chromecast/public/media/audio_device_ids.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698