chromecast/public/media/audio_device_ids.h - Issue 2701613006: [Chromecast] Process streams with different post-processing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromecast/public/media/audio_device_ids.h

Issue 2701613006: [Chromecast] Process streams with different post-processing. (Closed)

Patch Set: Fix nits Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromecast/media/service/cast_renderer.cc ('K') | « chromecast/public/media/BUILD.gn ('k') | chromecast/public/media/audio_device_ids.cc » ('j') | chromecast/public/media/media_pipeline_device_params.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROMECAST_PUBLIC_MEDIA_AUDIO_DEVICE_IDS_H_

	6 #define CHROMECAST_PUBLIC_MEDIA_AUDIO_DEVICE_IDS_H_

	7

	8 namespace chromecast {

	9 namespace media {

	10

	11 extern const char kAlarmAudioDeviceId[];

	12 extern const char kEarconAudioDeviceId[];

	13 extern const char kTtsAudioDeviceId[];

	14 extern const char kSystemAudioDeviceId[];

	15

	16 const int kDefaultAudioStreamType = 0;
	tianyuwang1 2017/02/18 00:17:09 do we still need the int types? do we still need the int types? bshaya 2017/02/21 23:30:14 +kmackay The int types are currently used for volu Show quoted text On 2017/02/18 00:17:09, tianyuwang1 wrote: > do we still need the int types? +kmackay The int types are currently used for volume control. The DeviceId's don't have a 1:1 correspondence with StreamType tianyuwang1 2017/02/23 20:25:37 We can get rid of the int type. Just use string i Show quoted text On 2017/02/21 23:30:14, bshaya wrote: > On 2017/02/18 00:17:09, tianyuwang1 wrote: > > do we still need the int types? > > +kmackay > The int types are currently used for volume control. The DeviceId's don't have a > 1:1 correspondence with StreamType We can get rid of the int type. Just use string is enough. Don't need to do the conversion. kmackay 2017/02/23 20:32:00 Agree, see https://eureka-internal-review.git.corp Show quoted text On 2017/02/23 20:25:37, tianyuwang1 wrote: > On 2017/02/21 23:30:14, bshaya wrote: > > On 2017/02/18 00:17:09, tianyuwang1 wrote: > > > do we still need the int types? > > > > +kmackay > > The int types are currently used for volume control. The DeviceId's don't have > a > > 1:1 correspondence with StreamType > > We can get rid of the int type. Just use string is enough. Don't need to do > the conversion. Agree, see https://eureka-internal-review.git.corp.google.com/#/c/65141/ where I did the same thing bshaya 2017/02/24 00:17:06 I'm leaving this for now, since Ken is already rem Show quoted text On 2017/02/23 20:32:00, kmackay wrote: > On 2017/02/23 20:25:37, tianyuwang1 wrote: > > On 2017/02/21 23:30:14, bshaya wrote: > > > On 2017/02/18 00:17:09, tianyuwang1 wrote: > > > > do we still need the int types? > > > > > > +kmackay > > > The int types are currently used for volume control. The DeviceId's don't > have > > a > > > 1:1 correspondence with StreamType > > > > We can get rid of the int type. Just use string is enough. Don't need to do > > the conversion. > > Agree, see https://eureka-internal-review.git.corp.google.com/#/c/65141/ where I > did the same thing I'm leaving this for now, since Ken is already removing the int types in his CL.
	17 const int kAlarmAudioStreamType = 1;

	18 const int kTtsAudioStreamType = 2;

	19

	20 } // namespace media

	21 } // namespace chromecast

	22

	23 #endif // CHROMECAST_PUBLIC_MEDIA_AUDIO_DEVICE_IDS_H_

OLD	NEW