chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java - Issue 2701613005: remove unnecessary thread hopping when updating Download notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Issue 2701613005: remove unnecessary thread hopping when updating Download notifications (Closed)

Patch Set: addressing comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

index 11936951c1eeddd5d56a213fa84101d23e385d5d..bc487aa4ae4ad6fb8e8113f9151922fe24caa661 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

@@ -306,6 +306,16 @@ public class DownloadManagerServiceTest extends NativeLibraryTestBase {

public void resumeDownload(DownloadItem item, boolean hasUserGesture) {

mResumed = true;

}

+ @Override

+ protected void scheduleUpdateIfNeeded() {

+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {

+ @Override

+ public void run() {

+ DownloadManagerServiceForTest.super.scheduleUpdateIfNeeded();

+ }

+ });

+ }

}

@Override