Add assist to reparent Flutter widget

Add assist to reparent Flutter widget

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/7945b6544930c9c38f5f188f867460c63ba939b2

[messick, 2017-02-16 18:31:28]

messick@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[messick, 2017-02-16 20:17:08]

Single widget wrapping. Re-parenting a list of widgets, or multiple widgets that
are not yet in a list will come later.

[scheglov, 2017-02-16 22:00:56]

lgtm

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1599:
static const FLUTTER_WIDGET_NAME = "Widget";
Move constants to the top of the class.

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1606:
newExpr = node.getAncestor((node) => node is InstanceCreationExpression);
I suspect that this might be too wide.
How about:
new Button(my.object.refe^rence)?

We're not on the class name, but it is one of the ancestors.
Change it to be activated only on the constructor name (class + name) of a
InstanceCreationExpression.

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1622: if
(uri == null) {
AFAIK null has toString().

[Brian Wilkerson, 2017-02-16 22:12:56]

lgtm

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2701563003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1599:
static const FLUTTER_WIDGET_NAME = "Widget";
> Move constants to the top of the class.

By running the sorter so that there won't be churn later.

[messick, 2017-02-16 23:06:31]

I made the requested changes. You might want to double-check the logic in the
filter refinement, but I added a test to verify that it works.

It looks like I don't have permission to commit this patch. Can one of you do
it?

[Brian Wilkerson, 2017-02-16 23:23:21]

still lgtm

https://codereview.chromium.org/2701563003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2701563003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1606:
newExpr = node.getAncestor((node) => node is InstanceCreationExpression);
I suspect Konstantin was suggesting that we not look up what could be an
arbitrary distance, but that we look more explicitly at the expected structure,
something like:

if (node.parent is ConstructorName && node.parent.parent is
InstanceCreationExpression) {
  newExpr = node.parent.parent;
} else {
  return;
}

[scheglov, 2017-02-16 23:59:23]

lgtm

https://codereview.chromium.org/2701563003/diff/20001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/services/correction/assist_internal.dart
(right):

https://codereview.chromium.org/2701563003/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1606:
newExpr = node.getAncestor((node) => node is InstanceCreationExpression);
On 2017/02/16 23:23:20, Brian Wilkerson wrote:
> I suspect Konstantin was suggesting that we not look up what could be an
> arbitrary distance, but that we look more explicitly at the expected
structure,
> something like:
> 
> if (node.parent is ConstructorName && node.parent.parent is
> InstanceCreationExpression) {
>   newExpr = node.parent.parent;
> } else {
>   return;
> }

Acknowledged.

[messick, 2017-02-17 16:35:51]

Description was changed from

==========
Add assist to reparent Flutter widget
==========

to

==========
Add assist to reparent Flutter widget

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7945b6544930c9c38f5f188f867460c63ba939b2
==========

[messick, 2017-02-17 16:35:53]

Committed patchset #2 (id:20001) manually as
7945b6544930c9c38f5f188f867460c63ba939b2 (presubmit successful).