Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.cpp

Issue 2701553002: Touchmoves should not be suppressed if the touchstart is consumed (Closed)
Patch Set: remove comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-in-slop-region.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/TouchEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.cpp b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
index 149cff36bc908842d65b6dc63fe73d9b538f3a66..2d91d0797f635d49aa79cfef3bd4dc09378d1f29 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
@@ -126,10 +126,6 @@ WebInputEventResult TouchEventManager::dispatchTouchEvents(
// http://www.w3.org/TR/touch-events/#touchevent-interface for how these
// lists fit together.
- // Suppress all the touch moves in the slop region.
- if (IsTouchSequenceStart(event))
- m_suppressingTouchmovesWithinSlop = true;
-
if (event.type() == WebInputEvent::TouchEnd ||
event.type() == WebInputEvent::TouchCancel || event.touchesLength > 1) {
m_suppressingTouchmovesWithinSlop = false;
@@ -292,6 +288,12 @@ WebInputEventResult TouchEventManager::dispatchTouchEvents(
}
}
+ // Do not suppress any touchmoves if the touchstart is consumed.
+ if (IsTouchSequenceStart(event) &&
+ eventResult == WebInputEventResult::NotHandled) {
+ m_suppressingTouchmovesWithinSlop = true;
+ }
+
return eventResult;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-in-slop-region.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698