Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/core/input/TouchEventManager.cpp

Issue 2701553002: Touchmoves should not be suppressed if the touchstart is consumed (Closed)
Patch Set: slop region Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-in-slop-region.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/TouchEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/TouchEventManager.cpp b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
index 149cff36bc908842d65b6dc63fe73d9b538f3a66..e97c665e0d10d25250f50a9cf9ae1a281fce515b 100644
--- a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/TouchEventManager.cpp
@@ -292,6 +292,13 @@ WebInputEventResult TouchEventManager::dispatchTouchEvents(
}
}
+ // Do not suppress any touchmoves if the touchstart is consumed.
Rick Byers 2017/02/16 21:21:57 nit: it seems like it would be a small clean-up to
mustaq 2017/02/16 21:41:26 The "true" value is used in Line 138, so we have t
Rick Byers 2017/02/16 22:09:19 But it's used only if we're currently processing a
lanwei 2017/02/17 15:11:17 Acknowledged. Yes, we can merge line 131 here, tha
+ if (m_suppressingTouchmovesWithinSlop &&
+ event.type() == WebInputEvent::TouchStart &&
+ eventResult != WebInputEventResult::NotHandled) {
+ m_suppressingTouchmovesWithinSlop = false;
+ }
+
return eventResult;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-in-slop-region.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698