chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm - Issue 270153004: Introduce ActiveScriptController; track active extension scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

Issue 270153004: Introduce ActiveScriptController; track active extension scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: UMA Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

index f0af376e7eb9e41ea0ab29435e88d506ac9b4173..5860757a9ff91a75feaf0aedf0b531ae208df85c 100644

--- a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

+++ b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

@@ -104,8 +104,8 @@ bool PageActionDecoration::ActivatePageAction(NSRect frame) {

extensions::TabHelper::FromWebContents(web_contents)->

location_bar_controller();

- // 1 is left click.

- switch (controller->OnClicked(page_action_->extension_id(), 1)) {

+ switch (controller->OnClicked(page_action_,

+ LocationBarController::MOUSE_BUTTON_LEFT)) {

case LocationBarController::ACTION_NONE:

break;