Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3823)

Unified Diff: chrome/browser/extensions/script_executor.cc

Issue 270153004: Introduce ActiveScriptController; track active extension scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: UMA Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/script_executor.cc
diff --git a/chrome/browser/extensions/script_executor.cc b/chrome/browser/extensions/script_executor.cc
index 45f6fc5530a20e429aa06e26beaf4004c97b584a..222d9046929814346c9d952faf124af7bf82bc8c 100644
--- a/chrome/browser/extensions/script_executor.cc
+++ b/chrome/browser/extensions/script_executor.cc
@@ -7,6 +7,9 @@
#include "base/callback.h"
#include "base/logging.h"
#include "base/pickle.h"
+#include "chrome/browser/extensions/active_script_controller.h"
+#include "chrome/browser/extensions/location_bar_controller.h"
+#include "chrome/browser/extensions/tab_helper.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
@@ -120,6 +123,13 @@ void ScriptExecutor::ExecuteScript(const std::string& extension_id,
bool user_gesture,
ScriptExecutor::ResultType result_type,
const ExecuteScriptCallback& callback) {
+ LocationBarController* location_bar_controller =
+ TabHelper::FromWebContents(web_contents_)->location_bar_controller();
+ // TODO(rdevlin.cronin): Now, this is just a notification. Soon, it should
+ // block until the user gives the OK to execute.
+ location_bar_controller->active_script_controller()->NotifyScriptExecuting(
+ extension_id);
+
ExtensionMsg_ExecuteCode_Params params;
params.request_id = next_request_id_++;
params.extension_id = extension_id;

Powered by Google App Engine
This is Rietveld 408576698