chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 270153004: Introduce ActiveScriptController; track active extension scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 270153004: Introduce ActiveScriptController; track active extension scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: UMA Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/activity_log/uma_policy.cc ('K') | « chrome/browser/extensions/activity_log/uma_policy.cc ('k') | chrome/browser/extensions/location_bar_controller.h » ('j') | chrome/browser/extensions/location_bar_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index 3b552b3cd30ea21b014c1c5073317db540926b07..af569073dc2a20e711fd5fb5991792f517426db0 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -398,6 +398,9 @@ void ExtensionActionAPI::ExtensionActionExecuted(

case ActionInfo::TYPE_SYSTEM_INDICATOR:

// The System Indicator handles its own clicks.

break;

+ case ActionInfo::TYPE_ACTIVE_SCRIPT:

+ NOTREACHED(); // We shouldn't get these calls (yet).

+ return;

}

if (event_name) {

@@ -620,6 +623,9 @@ void ExtensionActionFunction::NotifyChange() {

case ActionInfo::TYPE_SYSTEM_INDICATOR:

NotifySystemIndicatorChange();

return;

+ case ActionInfo::TYPE_ACTIVE_SCRIPT:

+ NOTREACHED(); // We shouldn't get these calls (yet).

+ return;

}

NOTREACHED();

}