Introduce ActiveScriptController; track active extension scripts

chrome/browser/extensions/script_executor.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/script_executor.h"
 
 #include "base/callback.h"
 #include "base/logging.h"
 #include "base/pickle.h"
+#include "chrome/browser/extensions/active_script_controller.h"
+#include "chrome/browser/extensions/location_bar_controller.h"
+#include "chrome/browser/extensions/tab_helper.h"
+#include "content/public/browser/navigation_controller.h"
+#include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "extensions/common/extension_messages.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 
 namespace base {
 class ListValue;
 }  // namespace base
@@ skipping 93 matching lines @@
                                    const std::string& code,
                                    ScriptExecutor::FrameScope frame_scope,
                                    UserScript::RunLocation run_at,
                                    ScriptExecutor::WorldType world_type,
                                    ScriptExecutor::ProcessType process_type,
                                    const GURL& webview_src,
                                    const GURL& file_url,
                                    bool user_gesture,
                                    ScriptExecutor::ResultType result_type,
                                    const ExecuteScriptCallback& callback) {
+  LocationBarController* location_bar_controller =
+      TabHelper::FromWebContents(web_contents_)->location_bar_controller();
+  // TODO(rdevlin.cronin): Now, this is just a notification. Soon, it should
+  // block until the user gives the OK to execute.
+  location_bar_controller->active_script_controller()->NotifyScriptExecuting(
+      extension_id,
+      web_contents_->GetController().GetVisibleEntry()->GetPageID());

[not at google - send to devlin, 2014/05/08 20:47:09]

now I remember why the old code implemented ScriptExecutor. So that it could
implement this via delegation.

no big deal. Observer interface might have been better.

[Devlin, 2014/05/08 23:01:00]

Yeah, I was debating it.  But wanted to keep the CL "small".

+
   ExtensionMsg_ExecuteCode_Params params;
   params.request_id = next_request_id_++;
   params.extension_id = extension_id;
   params.is_javascript = (script_type == JAVASCRIPT);
   params.code = code;
   params.all_frames = (frame_scope == ALL_FRAMES);
   params.run_at = static_cast<int>(run_at);
   params.in_main_world = (world_type == MAIN_WORLD);
   params.is_web_view = (process_type == WEB_VIEW_PROCESS);
   params.webview_src = webview_src;
   params.file_url = file_url;
   params.wants_result = (result_type == JSON_SERIALIZED_RESULT);
   params.user_gesture = user_gesture;
 
   // Handler handles IPCs and deletes itself on completion.
   new Handler(script_observers_, web_contents_, params, callback);
 }
 
 }  // namespace extensions