Introduce ActiveScriptController; track active extension scripts

chrome/browser/extensions/api/extension_action/extension_action_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 
 #include "base/base64.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 380 matching lines @@
   switch (extension_action.action_type()) {
     case ActionInfo::TYPE_BROWSER:
       event_name = "browserAction.onClicked";
       break;
     case ActionInfo::TYPE_PAGE:
       event_name = "pageAction.onClicked";
       break;
     case ActionInfo::TYPE_SYSTEM_INDICATOR:
       // The System Indicator handles its own clicks.
       break;
+    case ActionInfo::TYPE_ACTIVE_SCRIPT:
+      NOTREACHED();  // We shouldn't get these calls (yet).

[not at google - send to devlin, 2014/05/08 20:47:09]

even if we did I don't think we'll ever expose an API for them. so the "yet"
might be a little misleading :)

[Devlin, 2014/05/08 23:01:00]

Actually, since PageActions and ActiveScriptActions have to be able to be
combined now, we don't even use the new type. Removed.

+      return;
   }
 
   if (event_name) {
     scoped_ptr<base::ListValue> args(new base::ListValue());
     base::DictionaryValue* tab_value =
         extensions::ExtensionTabUtil::CreateTabValue(web_contents);
     args->Append(tab_value);
 
     DispatchEventToExtension(
         context, extension_action.extension_id(), event_name, args.Pass());
@@ skipping 202 matching lines @@
               ->GetBrowserAction(*extension_.get())) {
         NotifyBrowserActionChange();
       } else if (ExtensionActionManager::Get(GetProfile())
                      ->GetPageAction(*extension_.get())) {
         NotifyLocationBarChange();
       }
       return;
     case ActionInfo::TYPE_SYSTEM_INDICATOR:
       NotifySystemIndicatorChange();
       return;
+    case ActionInfo::TYPE_ACTIVE_SCRIPT:
+      NOTREACHED();  // We shouldn't get these calls (yet).
+      return;
   }
   NOTREACHED();
 }
 
 void ExtensionActionFunction::NotifyBrowserActionChange() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,
       content::Source<ExtensionAction>(extension_action_),
       content::Details<Profile>(GetProfile()));
 }
 
 void ExtensionActionFunction::NotifyLocationBarChange() {
-  TabHelper::FromWebContents(contents_)->
-      location_bar_controller()->NotifyChange();
+  LocationBarController::NotifyChange(contents_);
 }
 
 void ExtensionActionFunction::NotifySystemIndicatorChange() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_SYSTEM_INDICATOR_UPDATED,
       content::Source<Profile>(GetProfile()),
       content::Details<ExtensionAction>(extension_action_));
 }
 
 bool ExtensionActionFunction::SetVisible(bool visible) {
@@ skipping 255 matching lines @@
   content::NavigationEntry* entry = contents->GetController().GetVisibleEntry();
   if (!entry || url != entry->GetURL().spec()) {
     error_ = extensions::ErrorUtils::FormatErrorMessage(
         extensions::kUrlNotActiveError, url);
     return false;
   }
 
   // Set visibility and broadcast notifications that the UI should be updated.
   page_action->SetIsVisible(tab_id, enable);
   page_action->SetTitle(tab_id, title);
-  extensions::TabHelper::FromWebContents(contents)->
-      location_bar_controller()->NotifyChange();
+  extensions::LocationBarController::NotifyChange(contents);
 
   return true;
 }
 
 bool EnablePageActionsFunction::RunSync() {
   return SetPageActionEnabled(true);
 }
 
 bool DisablePageActionsFunction::RunSync() {
   return SetPageActionEnabled(false);
 }