Introduce ActiveScriptController; track active extension scripts

extensions/renderer/user_script_slave.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/user_script_slave.h"
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 176 matching lines @@
   if (frame->isViewSourceModeEnabled())
     data_source_url = GURL(content::kViewSourceScheme + std::string(":") +
                            data_source_url.spec());
 
   base::ElapsedTimer timer;
   int num_css = 0;
   int num_scripts = 0;
 
   ExecutingScriptsMap extensions_executing_scripts;
 
+  blink::WebFrame* top_frame = frame->top();
+  content::RenderView* render_view =

[not at google - send to devlin, 2014/05/07 22:49:02]

top_render_view?

[Devlin, 2014/05/08 18:15:46]

Why not.

+      content::RenderView::FromWebView(top_frame->view());
+
   for (size_t i = 0; i < scripts_.size(); ++i) {
     std::vector<WebScriptSource> sources;
     UserScript* script = scripts_[i];
 
     if (frame->parent() && !script->match_all_frames())
       continue;  // Only match subframes if the script declared it wanted to.
 
     const Extension* extension = extensions_->GetByID(script->extension_id());
 
     // Since extension info is sent separately from user script info, they can
     // be out of sync. We just ignore this situation.
     if (!extension)
       continue;
 
     // Content scripts are not tab-specific.
     const int kNoTabId = -1;
     // We don't have a process id in this context.
     const int kNoProcessId = -1;
     if (!PermissionsData::CanExecuteScriptOnPage(extension,
                                                  data_source_url,
-                                                 frame->top()->document().url(),
+                                                 top_frame->document().url(),
                                                  kNoTabId,
                                                  script,
                                                  kNoProcessId,
                                                  NULL)) {
       continue;
     }
 
     if (location == UserScript::DOCUMENT_START) {
       num_css += script->css_scripts().size();
       for (UserScript::FileList::const_iterator iter =
                script->css_scripts().begin();
            iter != script->css_scripts().end();
            ++iter) {
         frame->document().insertStyleSheet(
             WebString::fromUTF8(iter->GetContent().as_string()));
       }
     }
 
     if (script->run_location() == location) {
+      // TODO(rdevlin.cronin): Right now, this is just a notification, but soon
+      // we should block without user consent.
+      if (PermissionsData::ShouldNotifyForScriptExecution(extension)) {
+        render_view->Send(
+            new ExtensionHostMsg_NotifyExtensionScriptExecution(
+                render_view->GetRoutingID(),

[not at google - send to devlin, 2014/05/07 22:49:02]

(need page ID)

[Devlin, 2014/05/08 18:15:46]

Done.

+                extension->id()));
+      }
       num_scripts += script->js_scripts().size();
       for (size_t j = 0; j < script->js_scripts().size(); ++j) {
         UserScript::File& file = script->js_scripts()[j];
         std::string content = file.GetContent().as_string();
 
         // We add this dumb function wrapper for standalone user script to
         // emulate what Greasemonkey does.
         // TODO(aa): I think that maybe "is_standalone" scripts don't exist
         // anymore. Investigate.
         if (script->is_standalone() || script->emulate_greasemonkey()) {
@@ skipping 28 matching lines @@
            iter != sources.end();
            ++iter) {
         extensions_executing_scripts[extension->id()].insert(
             GURL(iter->url).path());
       }
     }
   }
 
   // Notify the browser if any extensions are now executing scripts.
   if (!extensions_executing_scripts.empty()) {
-    blink::WebFrame* top_frame = frame->top();
-    content::RenderView* render_view =
-        content::RenderView::FromWebView(top_frame->view());
     render_view->Send(new ExtensionHostMsg_ContentScriptsExecuting(
         render_view->GetRoutingID(),
         extensions_executing_scripts,
         render_view->GetPageId(),
         ScriptContext::GetDataSourceURLForFrame(top_frame)));
   }
 
   // Log debug info.
   if (location == UserScript::DOCUMENT_START) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.InjectStart_CssCount", num_css);
     UMA_HISTOGRAM_COUNTS_100("Extensions.InjectStart_ScriptCount", num_scripts);
     if (num_css || num_scripts)
       UMA_HISTOGRAM_TIMES("Extensions.InjectStart_Time", timer.Elapsed());
   } else if (location == UserScript::DOCUMENT_END) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.InjectEnd_ScriptCount", num_scripts);
     if (num_scripts)
       UMA_HISTOGRAM_TIMES("Extensions.InjectEnd_Time", timer.Elapsed());
   } else if (location == UserScript::DOCUMENT_IDLE) {
     UMA_HISTOGRAM_COUNTS_100("Extensions.InjectIdle_ScriptCount", num_scripts);
     if (num_scripts)
       UMA_HISTOGRAM_TIMES("Extensions.InjectIdle_Time", timer.Elapsed());
   } else {
     NOTREACHED();
   }
 }
 
 }  // namespace extensions