Introduce ActiveScriptController; track active extension scripts

chrome/browser/extensions/activity_log/uma_policy.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_UMA_POLICY_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_UMA_POLICY_H_
 
 #include <map>
 #include <string>
 
@@ skipping 78 matching lines @@
                             content::WebContents* contents,
                             int index) OVERRIDE;
 
   // Assign a status bitmask based on the action's properties.
   int MatchActionToStatus(scoped_refptr<Action> action);
 
   // When a page is opened, add it to the SiteMap url_status_.
   void SetupOpenedPage(const std::string& url);
 
   // When a page is closing, remove it from the SiteMap url_status_.
-  void CleanupClosedPage(const std::string& url);
+  void CleanupClosedPage(const std::string& url,
+                         content::WebContents* web_contents);
 
   // When a page is closing, save statistics about the page to histograms.
-  void HistogramOnClose(const std::string& url);
+  void HistogramOnClose(const std::string& url,
+                        content::WebContents* web_contents);

[not at google - send to devlin, 2014/05/07 22:49:02]

seems like the URL is implied by the web contents i.e. only need the single
argument.

[Devlin, 2014/05/08 18:15:46]

The url passed here has been cleaned via CleanURL(), so it would be a waste to
duplicate that effort, I think.  Thoughts?

[not at google - send to devlin, 2014/05/08 20:47:09]

I see what you mean. maybe call the variable clean_url then. and it would be
nice, where it matters, to DCHECK_EQ(clean_url, CleanURL(clean_url));

[Devlin, 2014/05/08 23:01:00]

Done.

 
   // Standardizes the way URLs are treated.
   static std::string CleanURL(const GURL& gurl);
 
   // Used by UmaPolicyTest.ProcessActionTest.
   SiteMap url_status() { return url_status_; }
 
   Profile* profile_;
 
   // URL -> extension id -> page status.
   SiteMap url_status_;
 
   // tab index -> URL.
   std::map<int32, std::string> tab_list_;
 
   FRIEND_TEST_ALL_PREFIXES(UmaPolicyTest, CleanURLTest);
   FRIEND_TEST_ALL_PREFIXES(UmaPolicyTest, MatchActionToStatusTest);
   FRIEND_TEST_ALL_PREFIXES(UmaPolicyTest, ProcessActionTest);
   FRIEND_TEST_ALL_PREFIXES(UmaPolicyTest, SiteUrlTest);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_UMA_POLICY_H_