Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 2701523007: Don't write magic numbers in script snapshots from gen_snapshot (Closed)
Patch Set: Add doc fix Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/gen_snapshot.cc
diff --git a/runtime/bin/gen_snapshot.cc b/runtime/bin/gen_snapshot.cc
index 2ecf34a10239fb87b7d4a4fa5333861627c2b847..40d1877114b8f2a2a87fa41a4462c4869c438081 100644
--- a/runtime/bin/gen_snapshot.cc
+++ b/runtime/bin/gen_snapshot.cc
@@ -702,7 +702,7 @@ static void PrintUsage() {
" libraries. \n"
" \n"
" To create a core snapshot: \n"
-" --snapshot-kind=core \n"
+" --snapshot_kind=core \n"
" --vm_snapshot_data=<output-file> \n"
" --isolate_snapshot_data=<output-file> \n"
" [<dart-script-file>] \n"
@@ -712,7 +712,7 @@ static void PrintUsage() {
" is created. \n"
" \n"
" To create a script snapshot with respect to a given core snapshot: \n"
-" --snapshot-kind=script \n"
+" --snapshot_kind=script \n"
" --vm_snapshot_data=<intput-file> \n"
" --isolate_snapshot_data=<intput-file> \n"
" --script_snapshot=<output-file> \n"
@@ -724,7 +724,7 @@ static void PrintUsage() {
" \n"
" To create an AOT application snapshot as blobs suitable for loading with \n"
" mmap: \n"
-" --snapshot-kind=app-aot-blobs \n"
+" --snapshot_kind=app-aot-blobs \n"
" --vm_snapshot_data=<output-file> \n"
" --vm_snapshot_instructions=<output-file> \n"
" --isolate_snapshot_data=<output-file> \n"
@@ -735,7 +735,7 @@ static void PrintUsage() {
" To create an AOT application snapshot as assembly suitable for compilation \n"
" as a static or dynamic library: \n"
" mmap: \n"
-" --snapshot-kind=app-aot-blobs \n"
+" --snapshot_kind=app-aot-blobs \n"
" --assembly=<output-file> \n"
" {--embedder_entry_points_manifest=<input-file>} \n"
" <dart-script-file> \n"
@@ -1136,7 +1136,7 @@ static void CreateAndWriteScriptSnapshot() {
CHECK_RESULT(result);
// Now write it out to the specified file.
- WriteSnapshotFile(script_snapshot_filename, buffer, size, true);
+ WriteSnapshotFile(script_snapshot_filename, buffer, size, false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698