Issue 2701523007: Don't write magic numbers in script snapshots from gen_snapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2701523007: Don't write magic numbers in script snapshots from gen_snapshot (Closed)

Created:
3 years, 10 months ago by goderbauer

Modified:
3 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't write magic numbers in script snapshots from gen_snapshot Also includes tiny doc fix. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/32220dddcfa4f3aa773425319cc41bcc1d4626c7

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	runtime/bin/gen_snapshot.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (3 generated)

rmacnak

LGTM For posterity: the magic number something the standalone embedder adds on top of the ...

3 years, 10 months ago (2017-02-17 23:00:27 UTC) #3

rmacnak

3 years, 10 months ago (2017-02-17 23:05:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
32220dddcfa4f3aa773425319cc41bcc1d4626c7 (presubmit successful).