Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2701523003: Don't pixel-snap overflow clips in clip paint property nodes. (Closed)
Patch Set: none Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
index 97c86a90bda984049055e0b145fb3ff3098e1256..de08bf5ec0fb40f8daca6a0daf9bb5537994d85c 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
@@ -3174,4 +3174,21 @@ TEST_P(PaintPropertyTreeBuilderTest, ScrollTranslationHasCompositorElementId) {
properties->scrollTranslation()->compositorElementId());
}
+TEST_P(PaintPropertyTreeBuilderTest, OverflowClipSubpixelPosition) {
+ setBodyInnerHTML(
+ "<style>body { margin: 20px 30px; }</style>"
+ "<div id='clipper'"
+ " style='position: relative; overflow: hidden; "
+ " width: 400px; height: 300px; left: 1.5px'>"
+ "</div>");
+
+ LayoutBoxModelObject* clipper = toLayoutBoxModelObject(
+ document().getElementById("clipper")->layoutObject());
+ const ObjectPaintProperties* clipProperties = clipper->paintProperties();
+
+ EXPECT_EQ(LayoutPoint(FloatPoint(31.5, 20)), clipper->paintOffset());
+ EXPECT_EQ(FloatRect(31.5, 20, 400, 300),
+ clipProperties->overflowClip()->clipRect().rect());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698