Begin adding top-level function declaration support to AstBuilder.

pkg/analyzer/test/generated/parser_fasta_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/generated/parser.dart' as analyzer;
 import 'package:front_end/src/fasta/analyzer/ast_builder.dart';
 import 'package:front_end/src/fasta/analyzer/element_store.dart';
@@ skipping 620 matching lines @@
   @override
   @failingTest
   void test_parseCompilationUnit_abstractAsPrefix_parameterized() {
     // TODO(paulberry): Unhandled event: Qualified
     super.test_parseCompilationUnit_abstractAsPrefix_parameterized();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnit_builtIn_asFunctionName() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry,ahe): Fasta's parser is confused when one of the built-in
+    // identifiers `export`, `import`, `library`, `part`, or `typedef` appears
+    // as the name of a top level function with an implicit return type.

[ahe, 2017/02/17 09:02:02]

I filed this bug: https://github.com/dart-lang/sdk/issues/28808

Perhaps you can use that instead of the TODO. Please don't hesitate to file bugs
like this against Fasta.

[Paul Berry, 2017/02/17 16:14:26]

Thanks.  I'll look through my recent CLs to see if there are other test failures
I've characterized well enough to file bugs for them.

     super.test_parseCompilationUnit_builtIn_asFunctionName();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnit_directives_multiple() {
     // TODO(paulberry): Unhandled event: LibraryName
     super.test_parseCompilationUnit_directives_multiple();
   }
 
@@ skipping 34 matching lines @@
 
   @override
   @failingTest
   void test_parseCompilationUnit_script() {
     // TODO(paulberry): No objects placed on stack
     super.test_parseCompilationUnit_script();
   }
 
   @override
   @failingTest
-  void test_parseCompilationUnit_skipFunctionBody_withInterpolation() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnit_skipFunctionBody_withInterpolation();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnit_topLevelDeclaration() {
     // TODO(paulberry): Unhandled event: ClassBody
     super.test_parseCompilationUnit_topLevelDeclaration();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnit_typedefAsPrefix() {
     // TODO(paulberry): TODO(paulberry,ahe): Fasta parser doesn't appear to handle this case correctly.
     super.test_parseCompilationUnit_typedefAsPrefix();
@@ skipping 30 matching lines @@
   @override
   @failingTest
   void test_parseCompilationUnitMember_finalVariable() {
     // TODO(paulberry): Unhandled event: FieldInitializer
     super.test_parseCompilationUnitMember_finalVariable();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_function_external_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): Implement AstBuilder.handleModifier
     super.test_parseCompilationUnitMember_function_external_noType();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_function_external_type() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): Implement AstBuilder.handleModifier
     super.test_parseCompilationUnitMember_function_external_type();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_function_generic_noReturnType() {
     // TODO(paulberry): Unhandled event: TypeVariable
     super.test_parseCompilationUnitMember_function_generic_noReturnType();
   }
 
@@ skipping 16 matching lines @@
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_function_generic_void() {
     // TODO(paulberry): Unhandled event: VoidKeyword
     super.test_parseCompilationUnitMember_function_generic_void();
   }
 
   @override
   @failingTest
-  void test_parseCompilationUnitMember_function_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnitMember_function_noType();
-  }
-
-  @override
-  @failingTest
-  void test_parseCompilationUnitMember_function_type() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnitMember_function_type();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnitMember_function_void() {
     // TODO(paulberry): Unhandled event: VoidKeyword
     super.test_parseCompilationUnitMember_function_void();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_getter_external_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): Implement AstBuilder.handleModifier
     super.test_parseCompilationUnitMember_getter_external_noType();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_getter_external_type() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): Implement AstBuilder.handleModifier
     super.test_parseCompilationUnitMember_getter_external_type();
   }
 
   @override
   @failingTest
-  void test_parseCompilationUnitMember_getter_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnitMember_getter_noType();
-  }
-
-  @override
-  @failingTest
-  void test_parseCompilationUnitMember_getter_type() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnitMember_getter_type();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnitMember_setter_external_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): Implement AstBuilder.handleModifier
     super.test_parseCompilationUnitMember_setter_external_noType();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_setter_external_type() {
     // TODO(paulberry): Unhandled event: VoidKeyword
     super.test_parseCompilationUnitMember_setter_external_type();
   }
 
   @override
   @failingTest
-  void test_parseCompilationUnitMember_setter_noType() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
-    super.test_parseCompilationUnitMember_setter_noType();
-  }
-
-  @override
-  @failingTest
   void test_parseCompilationUnitMember_setter_type() {
     // TODO(paulberry): Unhandled event: VoidKeyword
     super.test_parseCompilationUnitMember_setter_type();
   }
 
   @override
   @failingTest
   void test_parseCompilationUnitMember_typeAlias_abstract() {
     // TODO(paulberry): Unhandled event: TypeList
     super.test_parseCompilationUnitMember_typeAlias_abstract();
@@ skipping 198 matching lines @@
   @override
   @failingTest
   void test_parseExportDirective_show_hide() {
     // TODO(paulberry): Unhandled event: IdentifierList
     super.test_parseExportDirective_show_hide();
   }
 
   @override
   @failingTest
   void test_parseFunctionDeclaration_function() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): handle doc comments
     super.test_parseFunctionDeclaration_function();
   }
 
   @override
   @failingTest
   void test_parseFunctionDeclaration_functionWithTypeParameters() {
     // TODO(paulberry): Unhandled event: TypeVariable
     super.test_parseFunctionDeclaration_functionWithTypeParameters();
   }
 
   @override
   @failingTest
   void test_parseFunctionDeclaration_functionWithTypeParameters_comment() {
     // TODO(paulberry,ahe): generic method comment syntax is not supported by
     // Fasta.
     super.test_parseFunctionDeclaration_functionWithTypeParameters_comment();
   }
 
   @override
   @failingTest
   void test_parseFunctionDeclaration_getter() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): handle doc comments
     super.test_parseFunctionDeclaration_getter();
   }
 
   @override
   @failingTest
   void test_parseFunctionDeclaration_setter() {
-    // TODO(paulberry): Unhandled event: TopLevelMethod
+    // TODO(paulberry): handle doc comments
     super.test_parseFunctionDeclaration_setter();
   }
 
   @override
   @failingTest
   void test_parseImportDirective_configuration_multiple() {
     // TODO(paulberry): Unhandled event: Import
     super.test_parseImportDirective_configuration_multiple();
   }
 
@@ skipping 117 matching lines @@
     super.test_parseTypeAlias_function_typeParameters();
   }
 
   @override
   @failingTest
   void test_parseTypeAlias_function_voidReturnType() {
     // TODO(paulberry): Unhandled event: VoidKeyword
     super.test_parseTypeAlias_function_voidReturnType();
   }
 }