Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java

Issue 2701473008: Keep the reference to local private variable. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/apk/java/proguard.flags ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java b/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
index 97f84fb1e81cbee6f20dc287c69d84e1e3580e19..b22350e90043dd9265390f20e42aa5521e06f97f 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java
@@ -33,7 +33,9 @@ public class AwPdfExporter {
// Maintain a reference to the top level object (i.e. WebView) since in a common
// use case (offscreen webview) application may expect the framework's print manager
// to own the Webview (via PrintDocumentAdapter).
- // NOTE: it looks unused, but please do not remove this reference.
+ // NOTE: it looks unused, but please do not remove this reference. There is also a proguard
+ // configuration to prevent this variable to be optimized away. Any name changes should
+ // be reflected there.
private ViewGroup mContainerView;
AwPdfExporter(ViewGroup containerView) {
« no previous file with comments | « android_webview/apk/java/proguard.flags ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698