Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/chromeos/login/login_manager_test.cc

Issue 2701473007: Switch WindowedNotificationObserver to use base::RunLoop. (Closed)
Patch Set: Mention the bug; remove deferred quit in WaitForCondition. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/login_manager_test.cc
diff --git a/chrome/browser/chromeos/login/login_manager_test.cc b/chrome/browser/chromeos/login/login_manager_test.cc
index 354f2dc318f4475264c2bbdabcda73a3c1231611..5e9bcdb54b0f105ac89f227df43cde1534d2824a 100644
--- a/chrome/browser/chromeos/login/login_manager_test.cc
+++ b/chrome/browser/chromeos/login/login_manager_test.cc
@@ -201,6 +201,8 @@ void LoginManagerTest::LoginUser(const std::string& user_id) {
const UserContext user_context = CreateUserContext(user_id);
SetExpectedCredentials(user_context);
EXPECT_TRUE(TryToLogin(user_context));
+ // Let LoginDisplayHostImpl delete itself.
+ content::RunAllPendingInMessageLoop();
}
void LoginManagerTest::AddUser(const std::string& user_id) {
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698