Add failure screenshots and render test images to results detail.

build/android/pylib/instrumentation/instrumentation_test_instance.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import copy
 import json
 import logging
 import os
 import pickle
@@ skipping 480 matching lines @@
 
     self._timeout_scale = None
     self._initializeTestControlAttributes(args)
 
     self._coverage_directory = None
     self._initializeTestCoverageAttributes(args)
 
     self._store_tombstones = False
     self._initializeTombstonesAttributes(args)
 
+    self._should_save_images = None
     self._should_save_logcat = None
     self._initializeLogAttributes(args)
 
     self._edit_shared_prefs = []
     self._initializeEditPrefsAttributes(args)
 
   def _initializeApkAttributes(self, args, error_func):
     if args.apk_under_test:
       apk_under_test_path = args.apk_under_test
       if not args.apk_under_test.endswith('.apk'):
@@ skipping 160 matching lines @@
     self._timeout_scale = args.timeout_scale or 1
 
   def _initializeTestCoverageAttributes(self, args):
     self._coverage_directory = args.coverage_dir
 
   def _initializeTombstonesAttributes(self, args):
     self._store_tombstones = args.store_tombstones
 
   def _initializeLogAttributes(self, args):
     self._should_save_logcat = bool(args.json_results_file)
+    self._should_save_images = bool(args.json_results_file)
 
   def _initializeEditPrefsAttributes(self, args):
     if not hasattr(args, 'shared_prefs_file'):
       return
     if not isinstance(args.shared_prefs_file, str):
       logging.warning("Given non-string for a filepath")
       return
 
     # json.load() loads strings as unicode, which causes issues when trying
     # to edit string values in preference files, so convert to Python strings
@@ skipping 40 matching lines @@
 
   @property
   def edit_shared_prefs(self):
     return self._edit_shared_prefs
 
   @property
   def flags(self):
     return self._flags
 
   @property
+  def should_save_images(self):
+    return self._should_save_images
+
+  @property
   def should_save_logcat(self):
     return self._should_save_logcat
 
   @property
   def package_info(self):
     return self._package_info
 
   @property
   def screenshot_dir(self):
     return self._screenshot_dir
@@ skipping 118 matching lines @@
 
   @staticmethod
   def GenerateTestResults(
       result_code, result_bundle, statuses, start_ms, duration_ms):
     return GenerateTestResults(result_code, result_bundle, statuses,
                                start_ms, duration_ms)
 
   #override
   def TearDown(self):
     pass