Hide overlay play button if it can't be shown without clipping

third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/shadow/MediaControls.h"
 
 #include <limits>
 #include <memory>
 #include "core/HTMLNames.h"
 #include "core/css/StylePropertySet.h"
@@ skipping 153 matching lines @@
 
     // If scripts are not enabled, controls will always be shown.
     m_pageHolder->frame().settings()->setScriptEnabled(true);
   }
 
   void simulateRouteAvailabe() {
     m_mediaControls->mediaElement().remoteRouteAvailabilityChanged(
         WebRemotePlaybackAvailability::DeviceAvailable);
   }
 
-  void ensureLayout() {
-    // Force a relayout, so that the controls know the width.  Otherwise,
-    // they don't know if, for example, the cast button will fit.
-    m_mediaControls->mediaElement().clientWidth();
+  void ensureSizing() {
+    // Fire the size-change callback to ensure that the controls have
+    // been properly notified of the video size.
+    m_mediaControls->notifyElementSizeChanged(
+        m_mediaControls->mediaElement().getBoundingClientRect());
   }
 
   void simulateHideMediaControlsTimerFired() {
     m_mediaControls->hideMediaControlsTimerFired(nullptr);
   }
 
   void simulateLoadedMetadata() { m_mediaControls->onLoadedMetadata(); }
 
   MediaControls& mediaControls() { return *m_mediaControls; }
   MockVideoWebMediaPlayer* webMediaPlayer() {
@@ skipping 67 matching lines @@
   Document& document = this->document();
   int oldElementCount = document.styleEngine().styleForElementCount();
   // Also assert that there are no layouts yet.
   ASSERT_EQ(0, oldElementCount);
   mediaControls().reset();
   int newElementCount = document.styleEngine().styleForElementCount();
   ASSERT_EQ(oldElementCount, newElementCount);
 }
 
 TEST_F(MediaControlsTest, CastButtonRequiresRoute) {
-  ensureLayout();
+  ensureSizing();
   mediaControls().mediaElement().setBooleanAttribute(HTMLNames::controlsAttr,
                                                      true);
 
   Element* castButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-cast-button");
   ASSERT_NE(nullptr, castButton);
 
   ASSERT_FALSE(isElementVisible(*castButton));
 
   simulateRouteAvailabe();
   ASSERT_TRUE(isElementVisible(*castButton));
 }
 
 TEST_F(MediaControlsTest, CastButtonDisableRemotePlaybackAttr) {
-  ensureLayout();
+  ensureSizing();
   mediaControls().mediaElement().setBooleanAttribute(HTMLNames::controlsAttr,
                                                      true);
 
   Element* castButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-cast-button");
   ASSERT_NE(nullptr, castButton);
 
   ASSERT_FALSE(isElementVisible(*castButton));
   simulateRouteAvailabe();
   ASSERT_TRUE(isElementVisible(*castButton));
@@ skipping 66 matching lines @@
   mediaControls().show();
   mediaControls().toggleOverflowMenu();
   EXPECT_TRUE(isElementVisible(*overflowList));
 
   simulateHideMediaControlsTimerFired();
   EXPECT_TRUE(isElementVisible(*overflowList));
   EXPECT_TRUE(isElementVisible(*panel));
 }
 
 TEST_F(MediaControlsTest, DownloadButtonDisplayed) {
-  ensureLayout();
+  ensureSizing();
 
   Element* downloadButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-download-button");
   ASSERT_NE(nullptr, downloadButton);
 
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   simulateLoadedMetadata();
 
   // Download button should normally be displayed.
   EXPECT_TRUE(isElementVisible(*downloadButton));
 }
 
 TEST_F(MediaControlsTest, DownloadButtonNotDisplayedEmptyUrl) {
-  ensureLayout();
+  ensureSizing();
 
   Element* downloadButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-download-button");
   ASSERT_NE(nullptr, downloadButton);
 
   // Download button should not be displayed when URL is empty.
   mediaControls().mediaElement().setSrc("");
   testing::runPendingTasks();
   simulateLoadedMetadata();
   EXPECT_FALSE(isElementVisible(*downloadButton));
 }
 
 TEST_F(MediaControlsTest, DownloadButtonDisplayedHiddenAndDisplayed) {
-  ensureLayout();
+  ensureSizing();
 
   Element* downloadButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-download-button");
   ASSERT_NE(nullptr, downloadButton);
 
   // Initially show button.
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   simulateLoadedMetadata();
   EXPECT_TRUE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 
   // Hide button.
   mediaControls().mediaElement().setSrc("");
   testing::runPendingTasks();
   EXPECT_FALSE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 
   // Showing button again should not increment Shown count.
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   EXPECT_TRUE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 }
 
 TEST_F(MediaControlsTest, DownloadButtonRecordsClickOnlyOnce) {
-  ensureLayout();
+  ensureSizing();
 
   MediaControlDownloadButtonElement* downloadButton =
       static_cast<MediaControlDownloadButtonElement*>(
           getElementByShadowPseudoId(
               mediaControls(), "-internal-media-controls-download-button"));
   ASSERT_NE(nullptr, downloadButton);
 
   // Initially show button.
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
   simulateLoadedMetadata();
   EXPECT_TRUE(isElementVisible(*downloadButton));
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Shown, 1);
 
   // Click button once.
   downloadButton->dispatchSimulatedClick(
       Event::createBubble(EventTypeNames::click), SendNoEvents);
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Clicked, 1);
 
   // Clicking button again should not increment Clicked count.
   downloadButton->dispatchSimulatedClick(
       Event::createBubble(EventTypeNames::click), SendNoEvents);
   histogramTester().expectBucketCount("Media.Controls.Download",
                                       DownloadActionMetrics::Clicked, 1);
 }
 
 TEST_F(MediaControlsTest, DownloadButtonNotDisplayedInfiniteDuration) {
-  ensureLayout();
+  ensureSizing();
 
   Element* downloadButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-download-button");
   ASSERT_NE(nullptr, downloadButton);
 
   mediaControls().mediaElement().setSrc("https://example.com/foo.mp4");
   testing::runPendingTasks();
 
   // Download button should not be displayed when duration is infinite.
   mediaControls().mediaElement().durationChanged(
       std::numeric_limits<double>::infinity(), false /* requestSeek */);
   simulateLoadedMetadata();
   EXPECT_FALSE(isElementVisible(*downloadButton));
 }
 
 TEST_F(MediaControlsTest, DownloadButtonNotDisplayedHLS) {
-  ensureLayout();
+  ensureSizing();
 
   Element* downloadButton = getElementByShadowPseudoId(
       mediaControls(), "-internal-media-controls-download-button");
   ASSERT_NE(nullptr, downloadButton);
 
   // Download button should not be displayed for HLS streams.
   mediaControls().mediaElement().setSrc("https://example.com/foo.m3u8");
   testing::runPendingTasks();
   simulateLoadedMetadata();
   EXPECT_FALSE(isElementVisible(*downloadButton));
 }
 
 TEST_F(MediaControlsTest, TimelineSeekToRoundedEnd) {
-  ensureLayout();
+  ensureSizing();
 
   MediaControlTimelineElement* timeline =
       static_cast<MediaControlTimelineElement*>(getElementByShadowPseudoId(
           mediaControls(), "-webkit-media-controls-timeline"));
   ASSERT_NE(nullptr, timeline);
 
   // Tests the case where the real length of the video, |exactDuration|, gets
   // rounded up slightly to |roundedUpDuration| when setting the timeline's
   // |max| attribute (crbug.com/695065).
   double exactDuration = 596.586667;
   double roundedUpDuration = 596.587;
   loadMediaWithDuration(exactDuration);
 
   // Simulate a click slightly past the end of the track of the timeline's
   // underlying <input type="range">. This would set the |value| to the |max|
   // attribute, which can be slightly rounded relative to the duration.
   timeline->setValueAsNumber(roundedUpDuration, ASSERT_NO_EXCEPTION);
   ASSERT_EQ(roundedUpDuration, timeline->valueAsNumber());
   EXPECT_EQ(0.0, mediaControls().mediaElement().currentTime());
   timeline->dispatchInputEvent();
   EXPECT_EQ(exactDuration, mediaControls().mediaElement().currentTime());
 }
 
 TEST_F(MediaControlsTest, TimelineImmediatelyUpdatesCurrentTime) {
-  ensureLayout();
+  ensureSizing();
 
   MediaControlTimelineElement* timeline =
       static_cast<MediaControlTimelineElement*>(getElementByShadowPseudoId(
           mediaControls(), "-webkit-media-controls-timeline"));
   ASSERT_NE(nullptr, timeline);
   MediaControlCurrentTimeDisplayElement* currentTimeDisplay =
       static_cast<MediaControlCurrentTimeDisplayElement*>(
           getElementByShadowPseudoId(
               mediaControls(), "-webkit-media-controls-current-time-display"));
   ASSERT_NE(nullptr, currentTimeDisplay);
 
   double duration = 600;
   loadMediaWithDuration(duration);
 
   // Simulate seeking the underlying range to 50%. Current time display should
   // update synchronously (rather than waiting for media to finish seeking).
   timeline->setValueAsNumber(duration / 2, ASSERT_NO_EXCEPTION);
   timeline->dispatchInputEvent();
   EXPECT_EQ(duration / 2, currentTimeDisplay->currentValue());
 }
 
 }  // namespace blink