Hide overlay play button if it can't be shown without clipping

third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

 /*
  * Copyright (C) 2009 Apple Inc.
  * Copyright (C) 2009 Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 13 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/paint/MediaControlsPainter.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/html/HTMLMediaElement.h"
 #include "core/html/TimeRanges.h"
 #include "core/html/shadow/MediaControlElementTypes.h"
+#include "core/html/shadow/MediaControls.h"
 #include "core/layout/LayoutBox.h"
 #include "core/paint/PaintInfo.h"
 #include "core/style/ComputedStyle.h"
 #include "platform/graphics/Gradient.h"
 #include "platform/graphics/GraphicsContext.h"
 
 namespace blink {
 
 static const double kCurrentTimeBufferedDelta = 1.0;
 
@@ skipping 125 matching lines @@
     const LayoutObject& object,
     const PaintInfo& paintInfo,
     const IntRect& rect) {
   const HTMLMediaElement* mediaElement = toParentMediaElement(object);
   if (!mediaElement)
     return false;
 
   if (!hasSource(mediaElement) || !mediaElement->paused())
     return false;
 
+  MediaControlPanelElement* panelElement = nullptr;
+  if (mediaElement->mediaControls())
+    panelElement = mediaElement->mediaControls()->panelElement();
+
   static Image* mediaOverlayPlay = platformResource("mediaplayerOverlayPlay");
 
   IntRect buttonRect(rect);
 
   // Overlay play button covers the entire player, so center and draw a
   // smaller button.  Center in the entire element.
   // TODO(liberato): object.enclosingBox()?
   const LayoutBox* box = mediaElement->layoutObject()->enclosingBox();
   if (!box)
     return false;
   int mediaHeight = box->pixelSnappedHeight();
+  int mediaPanelHeight = 0;
+  if (panelElement)
+    mediaPanelHeight = panelElement->clientHeight();

[mlamouri (slow - plz ping), 2017/03/08 19:13:04]

I'm a huge fan of ternary operator and I would obviously recommend `int
mediaPanelHeight = panelElement ? panelElement->clientHeight() : 0;` but others
have different opinions that you can agree with :)

[steimel, 2017/03/09 16:42:24]

Done.

   buttonRect.setX(rect.center().x() - mediaOverlayPlayButtonWidth / 2);
   buttonRect.setY(rect.center().y() - mediaOverlayPlayButtonHeight / 2 +
-                  (mediaHeight - rect.height()) / 2);
+                  (mediaHeight - rect.height() - mediaPanelHeight) / 2);
   buttonRect.setWidth(mediaOverlayPlayButtonWidth);
   buttonRect.setHeight(mediaOverlayPlayButtonHeight);
 
   return paintMediaButton(paintInfo.context, buttonRect, mediaOverlayPlay);
 }
 
 static void paintRoundedSliderBackground(const IntRect& rect,
                                          const ComputedStyle& style,
                                          GraphicsContext& context,
                                          Color sliderBackgroundColor) {
@@ skipping 393 matching lines @@
 void MediaControlsPainter::adjustMediaSliderThumbSize(ComputedStyle& style) {
   const float zoomLevel = style.effectiveZoom();
 
   style.setWidth(
       Length(static_cast<int>(mediaSliderThumbTouchWidth * zoomLevel), Fixed));
   style.setHeight(
       Length(static_cast<int>(mediaSliderThumbTouchHeight * zoomLevel), Fixed));
 }
 
 }  // namespace blink