Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/core/dom/Range.idl

Issue 2701413003: Range: node offsets should be unsigned. (Closed)
Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Range.idl
diff --git a/third_party/WebKit/Source/core/dom/Range.idl b/third_party/WebKit/Source/core/dom/Range.idl
index d5a85672ac1ec6e7e973e45927eb6904247b0264..5c45326b79f6a9c2d0232170dc092e41ae5bdd99 100644
--- a/third_party/WebKit/Source/core/dom/Range.idl
+++ b/third_party/WebKit/Source/core/dom/Range.idl
@@ -19,21 +19,19 @@
*/
// https://dom.spec.whatwg.org/#interface-range
-
-// FIXME: All long types in this interface should be unsigned long.
[
Constructor,
ConstructorCallWith=Document,
] interface Range {
readonly attribute Node startContainer;
- readonly attribute long startOffset;
+ readonly attribute unsigned long startOffset;
readonly attribute Node endContainer;
- readonly attribute long endOffset;
+ readonly attribute unsigned long endOffset;
readonly attribute boolean collapsed;
readonly attribute Node commonAncestorContainer;
- [RaisesException] void setStart(Node node, long offset);
- [RaisesException] void setEnd(Node node, long offset);
+ [RaisesException] void setStart(Node node, unsigned long offset);
+ [RaisesException] void setEnd(Node node, unsigned long offset);
[RaisesException] void setStartBefore(Node node);
[RaisesException] void setStartAfter(Node node);
[RaisesException] void setEndBefore(Node node);
@@ -57,8 +55,8 @@
[NewObject] Range cloneRange();
[MeasureAs=RangeDetach] void detach();
- [RaisesException] boolean isPointInRange(Node node, long offset);
- [RaisesException] short comparePoint(Node node, long offset);
+ [RaisesException] boolean isPointInRange(Node node, unsigned long offset);
+ [RaisesException] short comparePoint(Node node, unsigned long offset);
[RaisesException] boolean intersectsNode(Node node);

Powered by Google App Engine
This is Rietveld 408576698