third_party/WebKit/Source/core/dom/NodeWithIndex.h - Issue 2701413003: Range: node offsets should be unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeWithIndex.h

Issue 2701413003: Range: node offsets should be unsigned. (Closed)

Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeWithIndex.h

diff --git a/third_party/WebKit/Source/core/dom/NodeWithIndex.h b/third_party/WebKit/Source/core/dom/NodeWithIndex.h

index 9d8fc495c1820b1e054b9ac20992adb57705caa4..aa749686f01374d0ee253e89166b713ea7960037 100644

--- a/third_party/WebKit/Source/core/dom/NodeWithIndex.h

+++ b/third_party/WebKit/Source/core/dom/NodeWithIndex.h

@@ -41,6 +41,7 @@ class NodeWithIndex {

Node& node() const { return *m_node; }

+ // TODO(tkent): Should be unsigned.

int index() const {

if (!hasIndex())

m_index = node().nodeIndex();