third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt - Issue 2701413003: Range: node offsets should be unsigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt

Issue 2701413003: Range: node offsets should be unsigned. (Closed)

Patch Set: Resolve std::numeric_limits<int>::max() leftover Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/text/selection-exceptions.html » ('j') | third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt

diff --git a/third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt b/third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt

index 83532dc4bc60b1ef3150569ce0dcbe6ad3ac0b4b..0aec32eaa545820fc08a918c42c723a7d2ce1b1b 100644

--- a/third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt

+++ b/third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt

@@ -1,7 +1,7 @@

foobarbaz

Success: window.getSelection() is ar.

-Success: s.extend(span2.firstChild, 4) raised IndexSizeError: Failed to execute 'extend' on 'Selection': The offset 4 is larger than or equal to the node's length (3)..

-Success: s.extend(span2.firstChild, -1) raised IndexSizeError: Failed to execute 'extend' on 'Selection': The offset -1 is larger than or equal to the node's length (3)..

+Success: s.extend(span2.firstChild, 4) raised IndexSizeError: Failed to execute 'extend' on 'Selection': The offset 4 is larger than the node's length (3)..

+Success: s.extend(span2.firstChild, -1) raised IndexSizeError: Failed to execute 'extend' on 'Selection': The offset 4294967295 is larger than the node's length (3)..

Success: window.getSelection() is b.

Success: window.getSelection() is arbaz.

Success: s.extend() raised TypeError: Failed to execute 'extend' on 'Selection': 1 argument required, but only 0 present..