Range: node offsets should be unsigned.

third_party/WebKit/Source/web/tests/TextFinderTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/TextFinder.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Document.h"
 #include "core/dom/NodeList.h"
 #include "core/dom/Range.h"
@@ skipping 67 matching lines @@
   int identifier = 0;
   WebString searchText(String("FindMe"));
   WebFindOptions findOptions;  // Default.
   bool wrapWithinFrame = true;
 
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   Range* activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(4, activeMatch->startOffset());
+  EXPECT_EQ(4u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(10, activeMatch->endOffset());
+  EXPECT_EQ(10u, activeMatch->endOffset());
 
   findOptions.findNext = true;
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(14, activeMatch->startOffset());
+  EXPECT_EQ(14u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(20, activeMatch->endOffset());
+  EXPECT_EQ(20u, activeMatch->endOffset());
 
   // Should wrap to the first match.
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(4, activeMatch->startOffset());
+  EXPECT_EQ(4u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(10, activeMatch->endOffset());
+  EXPECT_EQ(10u, activeMatch->endOffset());
 
   // Search in the reverse order.
   identifier = 1;
   findOptions = WebFindOptions();
   findOptions.forward = false;
 
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(14, activeMatch->startOffset());
+  EXPECT_EQ(14u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(20, activeMatch->endOffset());
+  EXPECT_EQ(20u, activeMatch->endOffset());
 
   findOptions.findNext = true;
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(4, activeMatch->startOffset());
+  EXPECT_EQ(4u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(10, activeMatch->endOffset());
+  EXPECT_EQ(10u, activeMatch->endOffset());
 
   // Wrap to the first match (last occurence in the document).
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textNode, activeMatch->startContainer());
-  EXPECT_EQ(14, activeMatch->startOffset());
+  EXPECT_EQ(14u, activeMatch->startOffset());
   EXPECT_EQ(textNode, activeMatch->endContainer());
-  EXPECT_EQ(20, activeMatch->endOffset());
+  EXPECT_EQ(20u, activeMatch->endOffset());
 }
 
 TEST_F(TextFinderTest, FindTextAutosizing) {
   document().body()->setInnerHTML("XXXXFindMeYYYYfindmeZZZZ");
   document().updateStyleAndLayout();
 
   int identifier = 0;
   WebString searchText(String("FindMe"));
   WebFindOptions findOptions;  // Default.
   bool wrapWithinFrame = true;
@@ skipping 58 matching lines @@
   bool wrapWithinFrame = true;
 
   // TextIterator currently returns the matches in the flat treeorder, so
   // in this case the matches will be returned in the order of
   // <i> -> <u> -> <b>.
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   Range* activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInIElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInIElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   findOptions.findNext = true;
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInUElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInUElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInBElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInBElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   // Should wrap to the first match.
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInIElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInIElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   // Fresh search in the reverse order.
   identifier = 1;
   findOptions = WebFindOptions();
   findOptions.forward = false;
 
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInBElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInBElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   findOptions.findNext = true;
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInUElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInUElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInIElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInIElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 
   // And wrap.
   ASSERT_TRUE(
       textFinder().find(identifier, searchText, findOptions, wrapWithinFrame));
   activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_EQ(textInBElement, activeMatch->startContainer());
-  EXPECT_EQ(0, activeMatch->startOffset());
+  EXPECT_EQ(0u, activeMatch->startOffset());
   EXPECT_EQ(textInBElement, activeMatch->endContainer());
-  EXPECT_EQ(3, activeMatch->endOffset());
+  EXPECT_EQ(3u, activeMatch->endOffset());
 }
 
 TEST_F(TextFinderTest, ScopeTextMatchesSimple) {
   document().body()->setInnerHTML("XXXXFindMeYYYYfindmeZZZZ");
   document().updateStyleAndLayout();
 
   Node* textNode = document().body()->firstChild();
 
   int identifier = 0;
   WebString searchText(String("FindMe"));
@@ skipping 170 matching lines @@
   Element* iElement = toElement(document().body()->lastChild());
   ASSERT_TRUE(iElement);
   iElement->setInnerHTML("ZZFindMe");
   document().updateStyleAndLayout();
 
   ASSERT_TRUE(textFinder().find(identifier, searchText, findOptions,
                                 wrapWithinFrame, &activeNow));
   Range* activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_FALSE(activeNow);
-  EXPECT_EQ(2, activeMatch->startOffset());
-  EXPECT_EQ(8, activeMatch->endOffset());
+  EXPECT_EQ(2u, activeMatch->startOffset());
+  EXPECT_EQ(8u, activeMatch->endOffset());
 
   // Restart full search and check that added text is found.
   findOptions.findNext = false;
   textFinder().resetMatchCount();
   textFinder().cancelPendingScopingEffort();
   textFinder().startScopingStringMatches(identifier, searchText, findOptions);
   while (textFinder().scopingInProgress())
     runPendingTasks();
   EXPECT_EQ(2, textFinder().totalMatchCount());
 
@@ skipping 32 matching lines @@
   Element* iElement = toElement(document().body()->lastChild());
   ASSERT_TRUE(iElement);
   iElement->setInnerHTML("ZZFindMe");
   document().updateStyleAndLayout();
 
   ASSERT_TRUE(textFinder().find(identifier, searchText, findOptions,
                                 wrapWithinFrame, &activeNow));
   Range* activeMatch = textFinder().activeMatch();
   ASSERT_TRUE(activeMatch);
   EXPECT_FALSE(activeNow);
-  EXPECT_EQ(2, activeMatch->startOffset());
-  EXPECT_EQ(8, activeMatch->endOffset());
+  EXPECT_EQ(2u, activeMatch->startOffset());
+  EXPECT_EQ(8u, activeMatch->endOffset());
 
   // Restart full search and check that added text is found.
   findOptions.findNext = false;
   textFinder().resetMatchCount();
   textFinder().cancelPendingScopingEffort();
   textFinder().startScopingStringMatches(identifier, searchText, findOptions);
   while (textFinder().scopingInProgress())
     runPendingTasks();
   EXPECT_EQ(1, textFinder().totalMatchCount());
 
@@ skipping 51 matching lines @@
   // of the TimeProxyPlatform timer is greater than timeout threshold.
   textFinder().startScopingStringMatches(identifier, searchPattern,
                                          findOptions);
   while (textFinder().scopingInProgress())
     runPendingTasks();
 
   EXPECT_EQ(4, textFinder().totalMatchCount());
 }
 
 }  // namespace blink