Range: node offsets should be unsigned.

third_party/WebKit/Source/core/dom/RangeTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/Range.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/Element.h"
 #include "core/dom/NodeList.h"
 #include "core/dom/Text.h"
@@ skipping 58 matching lines @@
   Range* range04 = Range::create(document(), oldText, 0, oldText, 4);
   Range* range02 = Range::create(document(), oldText, 0, oldText, 2);
   Range* range22 = Range::create(document(), oldText, 2, oldText, 2);
   Range* range24 = Range::create(document(), oldText, 2, oldText, 4);
 
   oldText->splitText(2, ASSERT_NO_EXCEPTION);
   Text* newText = toText(oldText->nextSibling());
 
   EXPECT_TRUE(range04->boundaryPointsValid());
   EXPECT_EQ(oldText, range04->startContainer());
-  EXPECT_EQ(0, range04->startOffset());
+  EXPECT_EQ(0u, range04->startOffset());
   EXPECT_EQ(newText, range04->endContainer());
-  EXPECT_EQ(2, range04->endOffset());
+  EXPECT_EQ(2u, range04->endOffset());
 
   EXPECT_TRUE(range02->boundaryPointsValid());
   EXPECT_EQ(oldText, range02->startContainer());
-  EXPECT_EQ(0, range02->startOffset());
+  EXPECT_EQ(0u, range02->startOffset());
   EXPECT_EQ(oldText, range02->endContainer());
-  EXPECT_EQ(2, range02->endOffset());
+  EXPECT_EQ(2u, range02->endOffset());
 
   // Our implementation always moves the boundary point at the separation point
   // to the end of the original text node.
   EXPECT_TRUE(range22->boundaryPointsValid());
   EXPECT_EQ(oldText, range22->startContainer());
-  EXPECT_EQ(2, range22->startOffset());
+  EXPECT_EQ(2u, range22->startOffset());
   EXPECT_EQ(oldText, range22->endContainer());
-  EXPECT_EQ(2, range22->endOffset());
+  EXPECT_EQ(2u, range22->endOffset());
 
   EXPECT_TRUE(range24->boundaryPointsValid());
   EXPECT_EQ(oldText, range24->startContainer());
-  EXPECT_EQ(2, range24->startOffset());
+  EXPECT_EQ(2u, range24->startOffset());
   EXPECT_EQ(newText, range24->endContainer());
-  EXPECT_EQ(2, range24->endOffset());
+  EXPECT_EQ(2u, range24->endOffset());
 }
 
 TEST_F(RangeTest, SplitTextNodeRangeOutsideText) {
   document().body()->setInnerHTML(
       "<span id=\"outer\">0<span id=\"inner-left\">1</span>SPLITME<span "
       "id=\"inner-right\">2</span>3</span>");
 
   Element* outer = document().getElementById(AtomicString::fromUTF8("outer"));
   Element* innerLeft =
       document().getElementById(AtomicString::fromUTF8("inner-left"));
   Element* innerRight =
       document().getElementById(AtomicString::fromUTF8("inner-right"));
   Text* oldText = toText(outer->childNodes()->item(2));
 
   Range* rangeOuterOutside = Range::create(document(), outer, 0, outer, 5);
   Range* rangeOuterInside = Range::create(document(), outer, 1, outer, 4);
   Range* rangeOuterSurroundingText =
       Range::create(document(), outer, 2, outer, 3);
   Range* rangeInnerLeft = Range::create(document(), innerLeft, 0, innerLeft, 1);
   Range* rangeInnerRight =
       Range::create(document(), innerRight, 0, innerRight, 1);
   Range* rangeFromTextToMiddleOfElement =
       Range::create(document(), oldText, 6, outer, 3);
 
   oldText->splitText(3, ASSERT_NO_EXCEPTION);
   Text* newText = toText(oldText->nextSibling());
 
   EXPECT_TRUE(rangeOuterOutside->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterOutside->startContainer());
-  EXPECT_EQ(0, rangeOuterOutside->startOffset());
+  EXPECT_EQ(0u, rangeOuterOutside->startOffset());
   EXPECT_EQ(outer, rangeOuterOutside->endContainer());
-  EXPECT_EQ(6,
+  EXPECT_EQ(6u,
             rangeOuterOutside
                 ->endOffset());  // Increased by 1 since a new node is inserted.
 
   EXPECT_TRUE(rangeOuterInside->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterInside->startContainer());
-  EXPECT_EQ(1, rangeOuterInside->startOffset());
+  EXPECT_EQ(1u, rangeOuterInside->startOffset());
   EXPECT_EQ(outer, rangeOuterInside->endContainer());
-  EXPECT_EQ(5, rangeOuterInside->endOffset());
+  EXPECT_EQ(5u, rangeOuterInside->endOffset());
 
   EXPECT_TRUE(rangeOuterSurroundingText->boundaryPointsValid());
   EXPECT_EQ(outer, rangeOuterSurroundingText->startContainer());
-  EXPECT_EQ(2, rangeOuterSurroundingText->startOffset());
+  EXPECT_EQ(2u, rangeOuterSurroundingText->startOffset());
   EXPECT_EQ(outer, rangeOuterSurroundingText->endContainer());
-  EXPECT_EQ(4, rangeOuterSurroundingText->endOffset());
+  EXPECT_EQ(4u, rangeOuterSurroundingText->endOffset());
 
   EXPECT_TRUE(rangeInnerLeft->boundaryPointsValid());
   EXPECT_EQ(innerLeft, rangeInnerLeft->startContainer());
-  EXPECT_EQ(0, rangeInnerLeft->startOffset());
+  EXPECT_EQ(0u, rangeInnerLeft->startOffset());
   EXPECT_EQ(innerLeft, rangeInnerLeft->endContainer());
-  EXPECT_EQ(1, rangeInnerLeft->endOffset());
+  EXPECT_EQ(1u, rangeInnerLeft->endOffset());
 
   EXPECT_TRUE(rangeInnerRight->boundaryPointsValid());
   EXPECT_EQ(innerRight, rangeInnerRight->startContainer());
-  EXPECT_EQ(0, rangeInnerRight->startOffset());
+  EXPECT_EQ(0u, rangeInnerRight->startOffset());
   EXPECT_EQ(innerRight, rangeInnerRight->endContainer());
-  EXPECT_EQ(1, rangeInnerRight->endOffset());
+  EXPECT_EQ(1u, rangeInnerRight->endOffset());
 
   EXPECT_TRUE(rangeFromTextToMiddleOfElement->boundaryPointsValid());
   EXPECT_EQ(newText, rangeFromTextToMiddleOfElement->startContainer());
-  EXPECT_EQ(3, rangeFromTextToMiddleOfElement->startOffset());
+  EXPECT_EQ(3u, rangeFromTextToMiddleOfElement->startOffset());
   EXPECT_EQ(outer, rangeFromTextToMiddleOfElement->endContainer());
-  EXPECT_EQ(4, rangeFromTextToMiddleOfElement->endOffset());
+  EXPECT_EQ(4u, rangeFromTextToMiddleOfElement->endOffset());
 }
 
 TEST_F(RangeTest, updateOwnerDocumentIfNeeded) {
   Element* foo = document().createElement("foo");
   Element* bar = document().createElement("bar");
   foo->appendChild(bar);
 
   Range* range = Range::create(document(), Position(bar, 0), Position(foo, 1));
 
   Document* anotherDocument = Document::create();
   anotherDocument->appendChild(foo);
 
   EXPECT_EQ(bar, range->startContainer());
-  EXPECT_EQ(0, range->startOffset());
+  EXPECT_EQ(0u, range->startOffset());
   EXPECT_EQ(foo, range->endContainer());
-  EXPECT_EQ(1, range->endOffset());
+  EXPECT_EQ(1u, range->endOffset());
 }
 
 // Regression test for crbug.com/639184
 TEST_F(RangeTest, NotMarkedValidByIrrelevantTextInsert) {
   document().body()->setInnerHTML(
       "<div><span id=span1>foo</span>bar<span id=span2>baz</span></div>");
 
   Element* div = document().querySelector("div");
   Element* span1 = document().getElementById("span1");
   Element* span2 = document().getElementById("span2");
   Text* text = toText(div->childNodes()->item(1));
 
   Range* range = Range::create(document(), span2, 0, div, 3);
 
   div->removeChild(span1);
   text->insertData(0, "bar", ASSERT_NO_EXCEPTION);
 
   EXPECT_TRUE(range->boundaryPointsValid());
   EXPECT_EQ(span2, range->startContainer());
-  EXPECT_EQ(0, range->startOffset());
+  EXPECT_EQ(0u, range->startOffset());
   EXPECT_EQ(div, range->endContainer());
-  EXPECT_EQ(2, range->endOffset());
+  EXPECT_EQ(2u, range->endOffset());
 }
 
 // Regression test for crbug.com/639184
 TEST_F(RangeTest, NotMarkedValidByIrrelevantTextRemove) {
   document().body()->setInnerHTML(
       "<div><span id=span1>foofoo</span>bar<span id=span2>baz</span></div>");
 
   Element* div = document().querySelector("div");
   Element* span1 = document().getElementById("span1");
   Element* span2 = document().getElementById("span2");
   Text* text = toText(div->childNodes()->item(1));
 
   Range* range = Range::create(document(), span2, 0, div, 3);
 
   div->removeChild(span1);
   text->deleteData(0, 3, ASSERT_NO_EXCEPTION);
 
   EXPECT_TRUE(range->boundaryPointsValid());
   EXPECT_EQ(span2, range->startContainer());
-  EXPECT_EQ(0, range->startOffset());
+  EXPECT_EQ(0u, range->startOffset());
   EXPECT_EQ(div, range->endContainer());
-  EXPECT_EQ(2, range->endOffset());
+  EXPECT_EQ(2u, range->endOffset());
 }
 
 }  // namespace blink