Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: chrome/browser/permissions/permission_context_base.h

Issue 2701343002: Implement permission embargo suppression metrics. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_context_base.h
diff --git a/chrome/browser/permissions/permission_context_base.h b/chrome/browser/permissions/permission_context_base.h
index 1957a449016b20f7ae6e7a9fc77b14bec338c837..cf995ef4293a31ca1a827318884e1b048935dc66 100644
--- a/chrome/browser/permissions/permission_context_base.h
+++ b/chrome/browser/permissions/permission_context_base.h
@@ -12,6 +12,7 @@
#include "base/memory/weak_ptr.h"
#include "build/build_config.h"
#include "chrome/browser/permissions/permission_request.h"
+#include "chrome/browser/permissions/permission_util.h"
#include "components/content_settings/core/common/content_settings.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/keyed_service/core/keyed_service.h"
@@ -29,32 +30,6 @@ class WebContents;
using BrowserPermissionCallback = base::Callback<void(ContentSetting)>;
-// Identifies the source or reason for a permission status being returned.
-// TODO(raymes): Add more reasons here and return them correctly.
-enum class PermissionStatusSource {
- // The status is the result of being blocked due to the user dismissing a
- // permission prompt multiple times.
- MULTIPLE_DISMISSALS,
-
- // The status is the resultof being blocked because the permission is on the
- // safe browsing blacklist.
- SAFE_BROWSING_BLACKLIST,
-
- // The reason for the status is not specified. Avoid returning this value. It
- // only exists until code has been added to correctly return a source in all
- // cases.
- UNSPECIFIED
-};
-
-struct PermissionResult {
- PermissionResult(ContentSetting content_setting,
- PermissionStatusSource source);
- ~PermissionResult();
-
- ContentSetting content_setting;
- PermissionStatusSource source;
-};
-
// This base class contains common operations for granting permissions.
// It offers the following functionality:
// - Creates a permission request when needed.
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_context_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698