Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2701343002: Implement permission embargo suppression metrics. (Closed)
Patch Set: Addressing comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 1f6f48d65c9bf90c4609958126fe5610a92bcfd4..a64bed0df30930051d0d99dc6c3b47218e007617 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -369,7 +369,35 @@ void PermissionUmaUtil::PermissionRevoked(ContentSettingsType permission,
}
}
-void PermissionUmaUtil::RecordPermissionEmbargoStatus(
+void PermissionUmaUtil::RecordEmbargoPromptSuppression(
+ PermissionEmbargoStatus embargo_status) {
+ UMA_HISTOGRAM_ENUMERATION("Permissions.AutoBlocker.EmbargoPromptSuppression",
+ embargo_status,
+ PermissionEmbargoStatus::STATUS_NUM);
+}
+
+void PermissionUmaUtil::RecordEmbargoPromptSuppressionFromSource(
+ PermissionStatusSource source) {
+ // Explicitly switch to ensure that any new PermissionStatusSource values are
+ // dealt with appropriately.
+ switch (source) {
+ case PermissionStatusSource::MULTIPLE_DISMISSALS:
+ PermissionUmaUtil::RecordEmbargoPromptSuppression(
+ PermissionEmbargoStatus::REPEATED_DISMISSALS);
+ break;
+ case PermissionStatusSource::SAFE_BROWSING_BLACKLIST:
+ PermissionUmaUtil::RecordEmbargoPromptSuppression(
+ PermissionEmbargoStatus::PERMISSIONS_BLACKLISTING);
+ break;
+ case PermissionStatusSource::UNSPECIFIED:
+ case PermissionStatusSource::KILL_SWITCH:
+ // The permission wasn't under embargo, so don't record anything. We may
+ // embargo it later.
+ break;
+ }
+}
+
+void PermissionUmaUtil::RecordEmbargoStatus(
PermissionEmbargoStatus embargo_status) {
UMA_HISTOGRAM_ENUMERATION("Permissions.AutoBlocker.EmbargoStatus",
embargo_status,

Powered by Google App Engine
This is Rietveld 408576698